Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1257343002: GestureLongPress should be able to invoke BUBBLE_MODE_FAST_USER_SWITCH. (Closed)

Created:
5 years, 4 months ago by wjmaclean
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GestureLongPress should be able to invoke BUBBLE_MODE_FAST_USER_SWITCH. When multiple profiles are open, right-clicking the avatar menu button allows "fast switching" between them. This CL allows GestureLongPress, the touch analogue to right-clicking, to do the same. BUG=503563 Committed: https://crrev.com/1da0a603cecaa523e9ad6bb64335cb5f5c3d4185 Cr-Commit-Position: refs/heads/master@{#340880}

Patch Set 1 #

Patch Set 2 : Handle windows pathway. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
wjmaclean
Small CL, ptal?
5 years, 4 months ago (2015-07-28 15:23:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257343002/1
5 years, 4 months ago (2015-07-28 15:24:28 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 16:03:25 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257343002/20001
5 years, 4 months ago (2015-07-28 19:59:15 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 20:48:53 UTC) #9
wjmaclean
Small CL, ptal? (resending, since apparently had not properly set the 'reviewer' field first time ...
5 years, 4 months ago (2015-07-28 22:25:26 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-29 11:42:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257343002/20001
5 years, 4 months ago (2015-07-29 12:32:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 13:18:11 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 13:18:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1da0a603cecaa523e9ad6bb64335cb5f5c3d4185
Cr-Commit-Position: refs/heads/master@{#340880}

Powered by Google App Engine
This is Rietveld 408576698