Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 125713002: Implement UdpTransport for Cast (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
Reviewers:
mikhal1
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Implement UdpTransport for Cast This change is partially a cleanup and implementation of UdpTransport for Cast. As the name suggests it is a UDP transport mechanism for Cast using net::UdpSocket. A behavior change is that a Cast receiver can have sender IP address optional. Only after a packet is received that it can send packets. It will reply only to that address and ignore packets coming from a different address. If a sender address is given to Cast receiver then there is no change. BUG=331989 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243854

Patch Set 1 #

Total comments: 8

Patch Set 2 : fied comments #

Patch Set 3 : virtual dtor #

Patch Set 4 : warning #

Patch Set 5 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -252 lines) Patch
M media/cast/cast.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/test/receiver.cc View 1 2 3 4 6 chunks +42 lines, -23 lines 0 comments Download
M media/cast/test/sender.cc View 1 2 3 4 5 chunks +31 lines, -22 lines 0 comments Download
M media/cast/transport/cast_transport.gyp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/transport/transport/transport.cc View 1 1 chunk +0 lines, -205 lines 0 comments Download
A media/cast/transport/transport/udp_transport.h View 1 1 chunk +68 lines, -0 lines 0 comments Download
A media/cast/transport/transport/udp_transport.cc View 1 2 3 1 chunk +153 lines, -0 lines 0 comments Download
A media/cast/transport/transport/udp_transport_unittest.cc View 1 2 3 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Alpha Left Google
6 years, 11 months ago (2014-01-07 05:21:40 UTC) #1
mikhal1
lgtm + nits https://chromiumcodereview.appspot.com/125713002/diff/1/media/cast/test/receiver.cc File media/cast/test/receiver.cc (right): https://chromiumcodereview.appspot.com/125713002/diff/1/media/cast/test/receiver.cc#newcode250 media/cast/test/receiver.cc:250: std::string remote_ip_address = media::cast::GetIpAddress("Enter sender IP."); ...
6 years, 11 months ago (2014-01-07 20:50:06 UTC) #2
Alpha Left Google
https://codereview.chromium.org/125713002/diff/1/media/cast/test/receiver.cc File media/cast/test/receiver.cc (right): https://codereview.chromium.org/125713002/diff/1/media/cast/test/receiver.cc#newcode250 media/cast/test/receiver.cc:250: std::string remote_ip_address = media::cast::GetIpAddress("Enter sender IP."); On 2014/01/07 20:50:06, ...
6 years, 11 months ago (2014-01-08 00:37:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/125713002/120001
6 years, 11 months ago (2014-01-08 00:40:09 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208846
6 years, 11 months ago (2014-01-08 01:03:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/125713002/360001
6 years, 11 months ago (2014-01-08 01:11:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=208857
6 years, 11 months ago (2014-01-08 01:34:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/125713002/360001
6 years, 11 months ago (2014-01-08 15:56:40 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=167268
6 years, 11 months ago (2014-01-08 16:58:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/125713002/720001
6 years, 11 months ago (2014-01-09 01:51:24 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=209652
6 years, 11 months ago (2014-01-09 04:10:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/125713002/990001
6 years, 11 months ago (2014-01-09 04:36:30 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:01:07 UTC) #13
Message was sent while issue was closed. 
Change committed as 243854

Powered by Google App Engine
This is Rietveld 408576698