Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 12570013: Disable failing test on chromium.fyi (Closed)

Created:
7 years, 9 months ago by timvolodine
Modified:
7 years, 9 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable failing test on chromium.fyi BUG=189186 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187910

Patch Set 1 #

Total comments: 2

Patch Set 2 : create new section and add bugId #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Beverloo
https://codereview.chromium.org/12570013/diff/1/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/12570013/diff/1/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode38 build/android/pylib/gtest/filter/content_browsertests_disabled:38: GpuPixelTestBrowserPlugin.MANUAL_BrowserPluginBlueBox You already filed bug 189186, why don't you ...
7 years, 9 months ago (2013-03-13 14:20:56 UTC) #1
timvolodine
https://codereview.chromium.org/12570013/diff/1/build/android/pylib/gtest/filter/content_browsertests_disabled File build/android/pylib/gtest/filter/content_browsertests_disabled (right): https://codereview.chromium.org/12570013/diff/1/build/android/pylib/gtest/filter/content_browsertests_disabled#newcode38 build/android/pylib/gtest/filter/content_browsertests_disabled:38: GpuPixelTestBrowserPlugin.MANUAL_BrowserPluginBlueBox On 2013/03/13 14:20:56, Peter Beverloo wrote: > You ...
7 years, 9 months ago (2013-03-13 14:42:05 UTC) #2
Peter Beverloo
lgtm
7 years, 9 months ago (2013-03-13 14:43:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/12570013/4001
7 years, 9 months ago (2013-03-13 14:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/12570013/4001
7 years, 9 months ago (2013-03-13 18:55:03 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 19:12:04 UTC) #6
Message was sent while issue was closed.
Change committed as 187910

Powered by Google App Engine
This is Rietveld 408576698