Disable ProfileShortcutManager for App Launcher (chrome.exe --show-app-list)

Disable ProfileShortcutManager for App Launcher (chrome.exe --show-app-list)

The existing code in ProfileShort assumes chrome.exe means Chrome Browser.  As a result, when a profile is created (in particular, when App Launcher is first run after install), it attempts to update Chrome shortcut, and ends up creating it, even though Chrome is not installed.

The minimal-effective solution is to disable ProfileShortcutManager if chrom.exe is run for App Launcher (via chrome.exe --show-app-list).

If we ever want to support profile shortcuts for App Launcher, we'll need to undo this change, and also update

profile_shortcut_manager_win.cc: CreateOrUpdateDesktopShortcutsForProfile()

to use ChromeAppHostDistribution, and scan for app_host.exe in shortcuts.

BUG=174849
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188121

[huangs, 2013-03-12 20:32:12]

PTAL.

[Alexei Svitkine (slow), 2013-03-12 20:34:10]

This seems reasonable.

Can you explain under what circumstances switches::kShowAppList gets used on the
command-line?

Does it ever get used if the Chrome browser is also installed?

[huangs, 2013-03-12 20:37:09]

kShowAppList (--show-app-list) is the switch used to run the App Launcher.  It
is invoked via the App Launcher shortcut:

app_host.exe --show-app-list

, which does maintenance, then calls chrome.exe passing the same parameters.

AFAIK it is unused if Chrome Browser is installed without the App Launcher.

[Alexei Svitkine (slow), 2013-03-12 20:53:51]

On 2013/03/12 20:37:09, huangs1 wrote:
> kShowAppList (--show-app-list) is the switch used to run the App Launcher.  It
> is invoked via the App Launcher shortcut:
> 
> app_host.exe --show-app-list
> 
> , which does maintenance, then calls chrome.exe passing the same parameters.
> 
> AFAIK it is unused if Chrome Browser is installed without the App Launcher.

What happens if both Chrome and the App Launcher are installed? Is that
parameter still passed?

[huangs, 2013-03-12 21:03:27]

It is passed when executing App Launcher.  Regular chrome.exe will not get
--show-app-list.

[Alexei Svitkine (slow), 2013-03-12 21:05:10]

Okay, LGTM in that case.

[Alexei Svitkine (slow), 2013-03-12 21:05:31]

+sail for profiles/ owners

[benwells, 2013-03-12 21:16:58]

lgtm

[huangs, 2013-03-14 02:48:01]

Ping sail@ for OWNER review.

[sail, 2013-03-14 04:08:29]

lgtm

[commit-bot: I haz the power, 2013-03-14 06:28:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/huangs@chromium.org/12570009/1

[commit-bot: I haz the power, 2013-03-14 17:45:44]

Change committed as 188121