Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: windows/README-Windows.txt

Issue 12568011: Update XZ Utils to 5.0.4 (third_party) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/xz/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: windows/README-Windows.txt
===================================================================
--- windows/README-Windows.txt (revision 87706)
+++ windows/README-Windows.txt (working copy)
@@ -90,11 +90,16 @@
lib /def:liblzma.def /out:liblzma.lib /machine:x64
- Linking against static liblzma should work too. Rename liblzma.a
- to e.g. liblzma_static.lib and tell MSVC to link against it. You
- also need to tell lzma.h to not use __declspec(dllimport) by defining
- the macro LZMA_API_STATIC. You can do it either in the C/C++ code
+ Linking against static liblzma might work too, but usually you
+ should use liblzma.dll if possible. (Or, if having a decompressor
+ is enough, consider using XZ Embedded or LZMA SDK which can be
+ compiled with MSVC.)
+ To try linking against static liblzma, rename liblzma.a to e.g.
+ liblzma_static.lib and tell MSVC to link against it. You also need
+ to tell lzma.h to not use __declspec(dllimport) by defining the
+ macro LZMA_API_STATIC. You can do it either in the C/C++ code
+
#define LZMA_API_STATIC
#include <lzma.h>
« README.chromium ('K') | « tests/test_scripts.sh ('k') | windows/build.bash » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698