Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 12559008: DevTools: add backend for discovering connected ADB devices. (Closed)

Created:
7 years, 9 months ago by pfeldman
Modified:
7 years, 9 months ago
Reviewers:
vsevik, James Hawkins, yurys
CC:
chromium-reviews, vsevik, yurys, pfeldman, arv+watch_chromium.org
Visibility:
Public.

Description

DevTools: add backend for discovering connected ADB devices. TBR=jhawkins (for minor InspectUI changes) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187310

Patch Set 1 #

Patch Set 2 : Lint #

Patch Set 3 : Same with Fetch for fetching discovery pages. #

Total comments: 4

Patch Set 4 : Extracted protocol http request helper. #

Total comments: 1

Patch Set 5 : Offline review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+654 lines, -17 lines) Patch
A chrome/browser/devtools/adb_client_socket.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/devtools/adb_client_socket.cc View 1 2 3 1 chunk +161 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_adb_bridge.h View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/devtools/devtools_adb_bridge.cc View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download
A chrome/browser/devtools/protocol_http_request.h View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/devtools/protocol_http_request.cc View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
M chrome/browser/resources/inspect/inspect.js View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.h View 1 2 3 4 3 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 2 3 4 8 chunks +77 lines, -17 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
7 years, 9 months ago (2013-03-10 14:11:22 UTC) #1
yurys
Please add more details to the description. https://codereview.chromium.org/12559008/diff/5001/chrome/browser/ui/webui/inspect_ui.cc File chrome/browser/ui/webui/inspect_ui.cc (right): https://codereview.chromium.org/12559008/diff/5001/chrome/browser/ui/webui/inspect_ui.cc#newcode387 chrome/browser/ui/webui/inspect_ui.cc:387: adb_bridge_->Stop(); Should ...
7 years, 9 months ago (2013-03-11 07:21:20 UTC) #2
vsevik
https://codereview.chromium.org/12559008/diff/5001/chrome/browser/devtools/adb_client_socket.cc File chrome/browser/devtools/adb_client_socket.cc (right): https://codereview.chromium.org/12559008/diff/5001/chrome/browser/devtools/adb_client_socket.cc#newcode17 chrome/browser/devtools/adb_client_socket.cc:17: std::string EncodeLength(size_t length) { HexEncode(&length, 2); https://codereview.chromium.org/12559008/diff/5001/chrome/browser/devtools/adb_client_socket.cc#newcode146 chrome/browser/devtools/adb_client_socket.cc:146: callback_.Run(std::string(), ...
7 years, 9 months ago (2013-03-11 11:47:13 UTC) #3
vsevik
https://codereview.chromium.org/12559008/diff/12001/chrome/browser/devtools/protocol_http_request.cc File chrome/browser/devtools/protocol_http_request.cc (right): https://codereview.chromium.org/12559008/diff/12001/chrome/browser/devtools/protocol_http_request.cc#newcode34 chrome/browser/devtools/protocol_http_request.cc:34: return; You are leaking ProtocolHttpRequest here.
7 years, 9 months ago (2013-03-11 15:25:00 UTC) #4
vsevik
lgtm
7 years, 9 months ago (2013-03-11 15:27:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/12559008/13013
7 years, 9 months ago (2013-03-11 15:41:41 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 17:37:42 UTC) #7
Message was sent while issue was closed.
Change committed as 187310

Powered by Google App Engine
This is Rietveld 408576698