Issue 12558005: [Android] Change jni_gen_dir to jni_gen_package for jni_generator.

Issue 12558005: [Android] Change jni_gen_dir to jni_gen_package for jni_generator. (Closed)

Created:
7 years, 9 months ago by Yaron

Modified:
7 years, 9 months ago

Reviewers:
cjhopman, Ben Goodger (Google), Torne

CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, ilevy+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org, John Knottenbelt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Change jni_gen_dir to jni_gen_package for jni_generator. With the old name it was getting relativized which is undesirable. See bug for more details. BUG=159133 TBR=ben (nobody really cares about this outside of build/ which cjhopman approved) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186803

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -29 lines)			Patch
M	android_webview/android_webview_tests.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	android_webview/native/webview_native.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/android/jni_generator/jni_generator.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/jar_file_jni_generator.gypi	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	build/jni_generator.gypi	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/navigation_interception.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/web_contents_delegate_android.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content.gyp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/content_jni.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_shell.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/media.gyp	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	net/net.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	testing/android/native_test.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ui.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12558005/1

7 years, 9 months ago (2013-03-07 02:14:10 UTC) #3

commit-bot: I haz the power

Presubmit check for 12558005-1 failed and returned exit status 1. INFO:root:Found 16 file(s). INFO:PRESUBMIT:Skipping pylint: ...

7 years, 9 months ago (2013-03-07 02:14:24 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12558005/1

7 years, 9 months ago (2013-03-07 16:36:37 UTC) #7

Message was sent while issue was closed.

Change committed as 186803

Expand Messages | Collapse Messages