Issue 1255703002: Don't force for fully split if initializers or updaters do.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1255703002: Don't force for fully split if initializers or updaters do. (Closed)

Created:
5 years, 5 months ago by Bob Nystrom

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org, sra1

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't force for fully split if initializers or updaters do. Fix #375. Fix #377. R=kevmoo@google.com Committed: 1af172bab8bdcd7039ef165a3c50060275ef7ee1

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/source_visitor.dart	View	3 chunks	+10 lines, -0 lines	0 comments	Download
A	test/regression/0300/0375.stmt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	test/regression/0300/0377.stmt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/splitting/loops.stmt	View	2 chunks	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

5 years, 5 months ago (2015-07-23 20:53:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1af172bab8bdcd7039ef165a3c50060275ef7ee1 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages