Adjust the profile sync service to properly set per user or per machine flags.

Adjust the profile sync service to properly set per user or per machine flags.

Since flags are handled differntly on ChromeOS now the sync service needs to
change the way it stores its flags until those are moved to proper prefs.

BUG=chromium-os:39250
TEST=Sync service experiments should still work.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187669

[pastarmovj, 2013-03-08 11:23:24]

Hey Nicolas,
I have fixed the way the sync service sets its flags until you make them proper
prefs as we discussed on the mail thread. It is important that this fix goes in
in case the move to prefs is delayed beyond the branch point.

Can you please review the CL.
Thanks!
Julian

[Nicolas Zea, 2013-03-08 18:56:20]

https://codereview.chromium.org/12549017/diff/1/chrome/browser/sync/profile_s...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/12549017/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_service.cc:2029: "sync-tab-favicons",
shouldn't this be the experiment string?

[pastarmovj, 2013-03-11 09:47:23]

https://codereview.chromium.org/12549017/diff/1/chrome/browser/sync/profile_s...
File chrome/browser/sync/profile_sync_service.cc (right):

https://codereview.chromium.org/12549017/diff/1/chrome/browser/sync/profile_s...
chrome/browser/sync/profile_sync_service.cc:2029: "sync-tab-favicons",
On 2013/03/08 18:56:21, Nicolas Zea wrote:
> shouldn't this be the experiment string?

Of course :) bad copy paste...bad

[Nicolas Zea, 2013-03-11 23:57:44]

lgtm

[commit-bot: I haz the power, 2013-03-12 12:32:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/12549017/9001

[commit-bot: I haz the power, 2013-03-12 12:40:33]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2013-03-12 17:23:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/12549017/9001

[commit-bot: I haz the power, 2013-03-12 22:39:26]

Change committed as 187669