content/browser/browser_plugin/browser_plugin_guest.cc - Issue 1254883006: Bubble scroll events from WebView guest to embedder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 1254883006: Bubble scroll events from WebView guest to embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Complete test. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/browser/frame_host/render_widget_host_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 6991a29f73f1a75947aa2c84d543412f422823cc..4b8cef72fde0bd91c2ef5e13ebae65bdf22ac212 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -465,6 +465,12 @@ WebContentsImpl* BrowserPluginGuest::GetWebContents() const {

return static_cast<WebContentsImpl*>(web_contents());

}

+void BrowserPluginGuest::SendScrollCompletion(bool handled) {

+ DCHECK(attached() && owner_web_contents_);

+ SendMessageToEmbedder(

+ new BrowserPluginMsg_SignalScrollCompletionEvent(handled));

gfx::Point BrowserPluginGuest::GetScreenCoordinates(

const gfx::Point& relative_position) const {

if (!attached())