chrome/browser/resources/options/startup_overlay.js - Issue 12548008: Really fix crash when dragging and dropping in chrome://settings/startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/startup_overlay.js

Issue 12548008: Really fix crash when dragging and dropping in chrome://settings/startup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Snip Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/browser_options_startup_page_list.js ('K') | « chrome/browser/resources/options/browser_options_startup_page_list.js ('k') | chrome/browser/ui/webui/options/startup_pages_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/startup_overlay.js

diff --git a/chrome/browser/resources/options/startup_overlay.js b/chrome/browser/resources/options/startup_overlay.js

index 860ac452c69c0b91a50c3f88627525caa0b56478..6cfa1c13de7003947859a51b01bf0a113d4cc9d1 100644

--- a/chrome/browser/resources/options/startup_overlay.js

+++ b/chrome/browser/resources/options/startup_overlay.js

@@ -126,7 +126,7 @@ cr.define('options', function() {

var model = new ArrayDataModel(pages);

// Add a "new page" row.

model.push({

Dan Beam 2013/03/09 00:22:04 nit: make 1 line, IMO model.push({modelIndex: -

dcheng 2013/03/09 01:06:22 Done.

- 'modelIndex': '-1'

+ 'modelIndex': -1

});

$('startupPagesList').dataModel = model;