Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5418)

Unified Diff: chrome/browser/history/shortcuts_backend_unittest.cc

Issue 12546016: Remove the Extensions URLRequestContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android webview init fix merged in. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/shortcuts_backend_unittest.cc
diff --git a/chrome/browser/history/shortcuts_backend_unittest.cc b/chrome/browser/history/shortcuts_backend_unittest.cc
index 985c8c45a37c675055ecf9f3849661f1271c4175..0a413aa7805c74472afcf69ff8f892c201c8a38f 100644
--- a/chrome/browser/history/shortcuts_backend_unittest.cc
+++ b/chrome/browser/history/shortcuts_backend_unittest.cc
@@ -3,8 +3,8 @@
// found in the LICENSE file.
#include "base/files/scoped_temp_dir.h"
-#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
+#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
@@ -12,7 +12,7 @@
#include "chrome/browser/history/shortcuts_backend_factory.h"
#include "chrome/browser/history/shortcuts_database.h"
#include "chrome/test/base/testing_profile.h"
-#include "content/public/test/test_browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "sql/statement.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -27,9 +27,7 @@ class ShortcutsBackendTest : public testing::Test,
public ShortcutsBackend::ShortcutsBackendObserver {
public:
ShortcutsBackendTest()
- : ui_thread_(BrowserThread::UI, &ui_message_loop_),
- db_thread_(BrowserThread::DB),
- load_notified_(false),
+ : load_notified_(false),
changed_notified_(false) {}
virtual void SetUp();
@@ -40,18 +38,16 @@ class ShortcutsBackendTest : public testing::Test,
void InitBackend();
+ content::TestBrowserThreadBundle thread_bundle_;
TestingProfile profile_;
scoped_refptr<ShortcutsBackend> backend_;
- base::MessageLoopForUI ui_message_loop_;
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread db_thread_;
bool load_notified_;
bool changed_notified_;
+ base::RunLoop on_loaded_loop_;
};
void ShortcutsBackendTest::SetUp() {
- db_thread_.Start();
ShortcutsBackendFactory::GetInstance()->SetTestingFactoryAndUse(
&profile_, &ShortcutsBackendFactory::BuildProfileForTesting);
backend_ = ShortcutsBackendFactory::GetForProfile(&profile_);
@@ -61,12 +57,11 @@ void ShortcutsBackendTest::SetUp() {
void ShortcutsBackendTest::TearDown() {
backend_->RemoveObserver(this);
- db_thread_.Stop();
}
void ShortcutsBackendTest::OnShortcutsLoaded() {
load_notified_ = true;
- base::MessageLoop::current()->Quit();
+ on_loaded_loop_.Quit();
}
void ShortcutsBackendTest::OnShortcutsChanged() {
@@ -79,7 +74,7 @@ void ShortcutsBackendTest::InitBackend() {
ASSERT_TRUE(backend);
ASSERT_FALSE(load_notified_);
ASSERT_FALSE(backend_->initialized());
- base::MessageLoop::current()->Run();
+ on_loaded_loop_.Run();
EXPECT_TRUE(load_notified_);
EXPECT_TRUE(backend_->initialized());
}
« no previous file with comments | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | chrome/browser/history/shortcuts_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698