Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

Issue 12546016: Remove the Extensions URLRequestContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android webview init fix merged in. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
index 7e02b8352514912eb78b27ffe250f0363abce969..532d89e52cf98df4226861ab73cbbcbca6d4689d 100644
--- a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc
@@ -7,6 +7,8 @@
#include "base/bind.h"
#include "base/run_loop.h"
#include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/storage_partition.h"
+#include "content/public/common/url_constants.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/cookies/canonical_cookie.h"
#include "net/cookies/parsed_cookie.h"
@@ -21,25 +23,32 @@ class BrowsingDataCookieHelperTest : public testing::Test {
: testing_profile_(new TestingProfile()) {
}
+ net::CookieMonster* GetCookieMonster(const GURL& origin) {
+ using content::BrowserContext;
+ // Since it's a unittest, assume default StoragePartition.
+ return BrowserContext::GetDefaultStoragePartition(testing_profile_.get())->
+ GetCookieStoreForScheme(origin.scheme())->GetCookieMonster();
+ }
+
void CreateCookiesForTest() {
- scoped_refptr<net::CookieMonster> cookie_monster =
- testing_profile_->GetCookieMonster();
- cookie_monster->SetCookieWithOptionsAsync(
- GURL("http://www.google.com"), "A=1", net::CookieOptions(),
+ GURL origin1("http://www.google.com");
+ GURL origin2("http://www.gmail.google.com");
+ GetCookieMonster(origin1)->SetCookieWithOptionsAsync(
+ origin1, "A=1", net::CookieOptions(),
net::CookieMonster::SetCookiesCallback());
- cookie_monster->SetCookieWithOptionsAsync(
- GURL("http://www.gmail.google.com"), "B=1", net::CookieOptions(),
+ GetCookieMonster(origin2)->SetCookieWithOptionsAsync(
+ origin2, "B=1", net::CookieOptions(),
net::CookieMonster::SetCookiesCallback());
}
void CreateCookiesForDomainCookieTest() {
- scoped_refptr<net::CookieMonster> cookie_monster =
- testing_profile_->GetCookieMonster();
+ GURL origin("http://www.google.com");
+ scoped_refptr<net::CookieMonster> cookie_monster = GetCookieMonster(origin);
cookie_monster->SetCookieWithOptionsAsync(
- GURL("http://www.google.com"), "A=1", net::CookieOptions(),
+ origin, "A=1", net::CookieOptions(),
net::CookieMonster::SetCookiesCallback());
cookie_monster->SetCookieWithOptionsAsync(
- GURL("http://www.google.com"), "A=2; Domain=.www.google.com ",
+ origin, "A=2; Domain=.www.google.com ",
net::CookieOptions(), net::CookieMonster::SetCookiesCallback());
}

Powered by Google App Engine
This is Rietveld 408576698