Issue 12546003: Fix a crash in the owners check for a change without reviewers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12546003: Fix a crash in the owners check for a change without reviewers. (Closed)

Created:
7 years, 9 months ago by Dirk Pranke

Modified:
7 years, 9 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fix a crash in the owners check for a change without reviewers. If we uploaded a CL w/o any reviewers specified, and then ran the owners check on it (so that we had a Rietveld issue number) we would crash in a Python assertion. This wasn't caught in unit testing because of a limitation in the unit test scaffolding. TBR=maruel@chromium.org BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=186454

Patch Set 1 #

Patch Set 2 : fix _RietveldOwnerAndReviewers to never return None #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	presubmit_canned_checks.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/12546003/2001

7 years, 9 months ago (2013-03-06 17:13:01 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages