Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: net/quic/quic_stream_factory.cc

Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test leak Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory.cc
diff --git a/net/quic/quic_stream_factory.cc b/net/quic/quic_stream_factory.cc
index c5a5026a6d42e035094ce3bde18e2ba46cf8dcb0..1cb3ff367b805e83c36999e53d6a3668e2ef3efd 100644
--- a/net/quic/quic_stream_factory.cc
+++ b/net/quic/quic_stream_factory.cc
@@ -374,8 +374,8 @@ QuicClientSession* QuicStreamFactory::CreateSession(
clock_.get(), random_generator_, socket);
QuicConnection* connection = new QuicConnection(guid, addr, helper, false);
- QuicClientSession* session = new QuicClientSession(connection, helper, this,
- host, net_log.net_log());
+ QuicClientSession* session =
+ new QuicClientSession(connection, socket, this, host, net_log.net_log());
all_sessions_.insert(session); // owning pointer
return session;
}
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698