Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: net/quic/quic_connection_helper.h

Issue 12545035: Refactor QuicClientSession so that it owns the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test leak Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_helper.h
diff --git a/net/quic/quic_connection_helper.h b/net/quic/quic_connection_helper.h
index a1193713e89c3791185eab1d40be61adaccf939e..4f06ff31fcb1202e912a138f067ca4af5b13d975 100644
--- a/net/quic/quic_connection_helper.h
+++ b/net/quic/quic_connection_helper.h
@@ -55,11 +55,6 @@ class NET_EXPORT_PRIVATE QuicConnectionHelper
virtual void SetAckAlarm(QuicTime::Delta delay) OVERRIDE;
virtual void ClearAckAlarm() OVERRIDE;
- int Read(IOBuffer* buf, int buf_len, const CompletionCallback& callback);
- // TODO(wtc): these two methods should be able to report a failure.
- void GetLocalAddress(IPEndPoint* local_address);
- void GetPeerAddress(IPEndPoint* peer_address);
-
private:
friend class test::QuicConnectionHelperPeer;
@@ -79,7 +74,7 @@ class NET_EXPORT_PRIVATE QuicConnectionHelper
base::WeakPtrFactory<QuicConnectionHelper> weak_factory_;
base::TaskRunner* task_runner_;
- scoped_ptr<DatagramClientSocket> socket_;
+ DatagramClientSocket* socket_;
QuicConnection* connection_;
const QuicClock* clock_;
QuicRandom* random_generator_;
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698