Issue 12545030: NaCl SDK: Have hello world example to check for __pnacl__ instead of __CLANG__.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12545030: NaCl SDK: Have hello world example to check for pnacl instead of CLANG. (Closed)

Created:
7 years, 9 months ago by jvoung (off chromium)

Modified:
7 years, 9 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, binji, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl SDK: Have hello world example to check for __pnacl__ instead of __CLANG__. Alternatively, we could check for __clang__, but there isn't a __CLANG__. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187959

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	native_client_sdk/src/examples/hello_world/hello_world.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/12545030/1

7 years, 9 months ago (2013-03-13 21:58:25 UTC) #3

Message was sent while issue was closed.

Change committed as 187959

Expand Messages | Collapse Messages

Issue 12545030: NaCl SDK: Have hello world example to check for __pnacl__ instead of __CLANG__. (Closed)

Description

Patch Set 1 #

Messages

Issue 12545030: NaCl SDK: Have hello world example to check for pnacl instead of CLANG. (Closed)