Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12545026: ResizingHostObserver is created by the desktop environment together with other stubs. (Closed)

Created:
7 years, 9 months ago by alexeypa (please no reviews)
Modified:
7 years, 9 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

ResizingHostObserver is created by the desktop environment together with other stubs. ResizingHostObserver is responsible to resizing the host desktop so that it matches the client resolution. This CL makes the desktop environment responsible for creation of ResizingHostObserver object along with other stubs. Related changes: - Added a new interface: SessionController. Objects implementing it will be responsible for handling control events. The client resolution change is the only supported event at the moment. - Removed OnClientResolutionChanged() from the host status observer. - The multi-process host does not handle OnClientResolutionChanged() notifications at the moment. BUG=137696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187130

Patch Set 1 #

Total comments: 6

Patch Set 2 : CR feedback & rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -127 lines) Patch
M remoting/host/basic_desktop_environment.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/basic_desktop_environment.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M remoting/host/chromoting_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M remoting/host/client_session.h View 3 chunks +3 lines, -6 lines 0 comments Download
M remoting/host/client_session.cc View 6 chunks +11 lines, -4 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M remoting/host/desktop_environment.h View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 3 chunks +13 lines, -0 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M remoting/host/host_mock_objects.h View 5 chunks +15 lines, -3 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M remoting/host/host_status_observer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 3 chunks +12 lines, -0 lines 0 comments Download
A remoting/host/ipc_session_controller.h View 1 chunk +35 lines, -0 lines 0 comments Download
A remoting/host/ipc_session_controller.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 6 chunks +0 lines, -9 lines 0 comments Download
M remoting/host/resizing_host_observer.h View 1 chunk +11 lines, -17 lines 0 comments Download
M remoting/host/resizing_host_observer.cc View 2 chunks +23 lines, -39 lines 0 comments Download
M remoting/host/resizing_host_observer_unittest.cc View 9 chunks +31 lines, -30 lines 0 comments Download
A remoting/host/session_controller.h View 1 chunk +25 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 9 months ago (2013-03-09 00:35:57 UTC) #1
alexeypa (please no reviews)
FYI. I didn't rename ResizingHostObserver on purpose. I'll do it as a follow up CL.
7 years, 9 months ago (2013-03-09 00:36:49 UTC) #2
Jamie
lgtm https://chromiumcodereview.appspot.com/12545026/diff/1/remoting/host/client_session.cc File remoting/host/client_session.cc (right): https://chromiumcodereview.appspot.com/12545026/diff/1/remoting/host/client_session.cc#newcode100 remoting/host/client_session.cc:100: SkISize::Make(resolution.dips_width(), resolution.dips_height())); I don't feel strongly about the ...
7 years, 9 months ago (2013-03-09 00:53:18 UTC) #3
alexeypa (please no reviews)
https://chromiumcodereview.appspot.com/12545026/diff/1/remoting/host/client_session.cc File remoting/host/client_session.cc (right): https://chromiumcodereview.appspot.com/12545026/diff/1/remoting/host/client_session.cc#newcode100 remoting/host/client_session.cc:100: SkISize::Make(resolution.dips_width(), resolution.dips_height())); On 2013/03/09 00:53:18, Jamie wrote: > I ...
7 years, 9 months ago (2013-03-09 01:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12545026/4002
7 years, 9 months ago (2013-03-09 01:06:20 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-09 03:05:02 UTC) #6
Message was sent while issue was closed. 
Change committed as 187130

Powered by Google App Engine
This is Rietveld 408576698