Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: remoting/host/win/worker_process_launcher.h

Issue 12545006: The worker process launcher can now ask the worker to crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/win/worker_process_launcher.h
diff --git a/remoting/host/win/worker_process_launcher.h b/remoting/host/win/worker_process_launcher.h
index 1eea8cd0775d844daea07da9ba2b0c60cfd2be28..d8585dd0a149af961f1f1c76613ce85ddb039b9c 100644
--- a/remoting/host/win/worker_process_launcher.h
+++ b/remoting/host/win/worker_process_launcher.h
@@ -21,6 +21,10 @@ class Listener;
class Message;
} // namespace IPC
+namespace tracked_objects {
+class Location;
+} // namespace tracked_objects
+
namespace remoting {
class WorkerProcessIpcDelegate;
@@ -35,6 +39,9 @@ class WorkerProcessLauncher {
public:
virtual ~Delegate();
+ // Closes the IPC channel.
+ virtual void CloseChannel() = 0;
+
// Returns PID of the worker process or 0 if it is not available.
virtual DWORD GetProcessId() const = 0;
@@ -68,6 +75,12 @@ class WorkerProcessLauncher {
WorkerProcessIpcDelegate* worker_delegate);
~WorkerProcessLauncher();
+ // Asks the worker process to crash generating a dump and closes
Wez 2013/03/07 01:54:35 nit: "... crash and generate a dump, and ..."
alexeypa (please no reviews) 2013/03/07 21:28:30 Done.
+ // the IPC channel. |location| is passed to the worker so that it is included
+ // to the generated dump. Restarts the worker process forcefully, if it does
Wez 2013/03/07 01:54:35 nit: "... it is on the stack in the dump."
Wez 2013/03/07 01:54:35 nit: Does it always restart it, or just kill it an
alexeypa (please no reviews) 2013/03/07 21:28:30 Done.
alexeypa (please no reviews) 2013/03/07 21:28:30 It always restarts it. If the caller decide to sto
+ // not exit on its own.
+ void Crash(const tracked_objects::Location& location);
+
// Sends an IPC message to the worker process. The message will be silently
// dropped if Send() is called before Start() or after stutdown has been
// initiated.

Powered by Google App Engine
This is Rietveld 408576698