Issue 12545004: Fix Array.length, String.length and Function.prototype LoadICs on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12545004: Fix Array.length, String.length and Function.prototype LoadICs on x64. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Array.length, String.length and Function.prototype LoadICs on x64. R=jkummerow@chromium.org BUG=v8:2568 Committed: https://code.google.com/p/v8/source/detail?r=13847

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -15 lines)			Patch
	M	src/x64/code-stubs-x64.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-2568.js	View	1	1 chunk	+16 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. https://chromiumcodereview.appspot.com/12545004/diff/1/test/mjsunit/regress/regress-2568.js File test/mjsunit/regress/regress-2568.js (right): https://chromiumcodereview.appspot.com/12545004/diff/1/test/mjsunit/regress/regress-2568.js#newcode1 test/mjsunit/regress/regress-2568.js:1: // Copyright 2012 the V8 project ...

7 years, 9 months ago (2013-03-06 18:18:25 UTC) #2

Yang

7 years, 9 months ago (2013-03-06 18:19:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13847 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12545004: Fix Array.length, String.length and Function.prototype LoadICs on x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages