Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: remoting/host/client_session.h

Issue 12544019: Create a desktop environment instance late so that it will see the curtain_required flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/client_session.h
diff --git a/remoting/host/client_session.h b/remoting/host/client_session.h
index f0d1e51083c6ca7bb6cbcbf70e2a975e2f2901bc..966a1f851f051ed6c72558a0efb5e8e589fcbbb8 100644
--- a/remoting/host/client_session.h
+++ b/remoting/host/client_session.h
@@ -81,8 +81,7 @@ class ClientSession
virtual ~EventHandler() {}
};
- // |event_handler| must outlive |this|. |desktop_environment_factory| is only
- // used by the constructor to create an instance of DesktopEnvironment.
+ // |event_handler| and |desktop_environment_factory| must outlive |this|.
ClientSession(
EventHandler* event_handler,
scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner,
@@ -162,8 +161,8 @@ class ClientSession
std::string client_jid_;
- // The desktop environment used by this session.
- scoped_ptr<DesktopEnvironment> desktop_environment_;
+ // Used to create a DesktopEnvironment instance for this session.
+ DesktopEnvironmentFactory* desktop_environment_factory_;
// Filter used as the final element in the input pipeline.
protocol::InputFilter host_input_filter_;
« no previous file with comments | « no previous file | remoting/host/client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698