Implement 'dart:typeddata' directly in the VM instead of using 'dart:scalarlist'

runtime/vm/raw_object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/raw_object.h"
 
 #include "vm/class_table.h"
 #include "vm/freelist.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 185 matching lines @@
         instance_size = Float32Array::InstanceSize(byte_array_length);
         break;
       }
       case kFloat64ArrayCid: {
         const RawFloat64Array* raw_byte_array =
             reinterpret_cast<const RawFloat64Array*>(this);
         intptr_t byte_array_length = Smi::Value(raw_byte_array->ptr()->length_);
         instance_size = Float64Array::InstanceSize(byte_array_length);
         break;
       }
+#define SIZE_FROM_CLASS(clazz)                                                 \
+      case kTypedData##clazz##Cid:
+      CLASS_LIST_TYPED_DATA(SIZE_FROM_CLASS) {
+        const RawTypedData* raw_obj =
+            reinterpret_cast<const RawTypedData*>(this);
+        intptr_t cid = raw_obj->GetClassId();
+        intptr_t array_len = Smi::Value(raw_obj->ptr()->length_);
+        intptr_t lengthInBytes = array_len * TypedData::ElementSizeInBytes(cid);
+        instance_size = TypedData::InstanceSize(lengthInBytes);
+        break;
+      }
+#undef SIZE_FROM_CLASS
+#define SIZE_FROM_CLASS(clazz)                                                 \
+      case kExternalTypedData##clazz##Cid:

[Ivan Posva, 2013/03/07 08:53:31]

This code should never be reached, as the size of the RawExternalTypeData object
does not depend on the length.

[siva, 2013/03/07 21:47:43]

True, I removed it.

On 2013/03/07 08:53:31, Ivan Posva wrote:

+      CLASS_LIST_TYPED_DATA(SIZE_FROM_CLASS) {
+        instance_size = ExternalTypedData::InstanceSize();
+        break;
+      }
+#undef SIZE_FROM_CLASS
       case kTypeArgumentsCid: {
         const RawTypeArguments* raw_array =
             reinterpret_cast<const RawTypeArguments*>(this);
         intptr_t array_length = Smi::Value(raw_array->ptr()->length_);
         instance_size = TypeArguments::InstanceSize(array_length);
         break;
       }
       case kPcDescriptorsCid: {
         const RawPcDescriptors* raw_descriptors =
             reinterpret_cast<const RawPcDescriptors*>(this);
@@ skipping 68 matching lines @@
   if (class_id < kNumPredefinedCids) {
     switch (class_id) {
 #define RAW_VISITPOINTERS(clazz)                                               \
       case clazz::kClassId: {                                                  \
         Raw##clazz* raw_obj = reinterpret_cast<Raw##clazz*>(this);             \
         size = Raw##clazz::Visit##clazz##Pointers(raw_obj, visitor);           \
         break;                                                                 \
       }
       CLASS_LIST_NO_OBJECT(RAW_VISITPOINTERS)
 #undef RAW_VISITPOINTERS
+#define RAW_VISITPOINTERS(clazz)                                               \
+      case kTypedData##clazz##Cid:
+      CLASS_LIST_TYPED_DATA(RAW_VISITPOINTERS) {
+        RawTypedData* raw_obj = reinterpret_cast<RawTypedData*>(this);
+        size = RawTypedData::VisitTypedDataPointers(raw_obj, visitor);
+        break;
+      }
+#undef RAW_VISITPOINTERS
+#define RAW_VISITPOINTERS(clazz)                                               \
+      case kExternalTypedData##clazz##Cid:
+      CLASS_LIST_TYPED_DATA(RAW_VISITPOINTERS) {
+        RawExternalTypedData* raw_obj =
+            reinterpret_cast<RawExternalTypedData*>(this);
+        size = RawExternalTypedData::VisitExternalTypedDataPointers(raw_obj,
+                                                                    visitor);
+        break;
+      }
+#undef RAW_VISITPOINTERS
       case kFreeListElement: {
         ASSERT(FreeBit::decode(ptr()->tags_));
         uword addr = RawObject::ToAddr(const_cast<RawObject*>(this));
         FreeListElement* element = reinterpret_cast<FreeListElement*>(addr);
         size = element->Size();
         break;
       }
       default:
         OS::Print("Class Id: %"Pd"\n", class_id);
         UNREACHABLE();
@@ skipping 688 matching lines @@
 
 intptr_t RawExternalUint64Array::VisitExternalUint64ArrayPointers(
     RawExternalUint64Array* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return ExternalUint64Array::InstanceSize();
 }
 
 
-intptr_t
-    RawExternalFloat32x4Array::VisitExternalFloat32x4ArrayPointers(
+intptr_t RawExternalFloat32x4Array::VisitExternalFloat32x4ArrayPointers(
     RawExternalFloat32x4Array* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return ExternalFloat32x4Array::InstanceSize();
 }
 
 
 intptr_t RawExternalFloat32Array::VisitExternalFloat32ArrayPointers(
     RawExternalFloat32Array* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return ExternalFloat32Array::InstanceSize();
 }
 
 
 intptr_t RawExternalFloat64Array::VisitExternalFloat64ArrayPointers(
     RawExternalFloat64Array* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return ExternalFloat64Array::InstanceSize();
 }
 
 
+intptr_t RawTypedData::VisitTypedDataPointers(
+    RawTypedData* raw_obj, ObjectPointerVisitor* visitor) {
+  // Make sure that we got here with the tagged pointer as this.
+  ASSERT(raw_obj->IsHeapObject());
+  intptr_t cid = raw_obj->GetClassId();
+  intptr_t array_len = Smi::Value(raw_obj->ptr()->length_);
+  intptr_t lengthInBytes = array_len * TypedData::ElementSizeInBytes(cid);
+  visitor->VisitPointers(raw_obj->from(), raw_obj->to());
+  return TypedData::InstanceSize(lengthInBytes);
+}
+
+
+intptr_t RawExternalTypedData::VisitExternalTypedDataPointers(
+    RawExternalTypedData* raw_obj, ObjectPointerVisitor* visitor) {
+  // Make sure that we got here with the tagged pointer as this.
+  ASSERT(raw_obj->IsHeapObject());
+  visitor->VisitPointers(raw_obj->from(), raw_obj->to());
+  return ExternalTypedData::InstanceSize();
+}
+
+
 intptr_t RawDartFunction::VisitDartFunctionPointers(
     RawDartFunction* raw_obj, ObjectPointerVisitor* visitor) {
   // Function (defined in core library) is an abstract class.
   UNREACHABLE();
   return 0;
 }
 
 
 intptr_t RawStacktrace::VisitStacktracePointers(RawStacktrace* raw_obj,
                                                 ObjectPointerVisitor* visitor) {
@@ skipping 16 matching lines @@
 
 intptr_t RawWeakProperty::VisitWeakPropertyPointers(
     RawWeakProperty* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return WeakProperty::InstanceSize();
 }
 
 }  // namespace dart