Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: chrome/browser/storage_monitor/volume_mount_watcher_win.cc

Issue 12544005: Consolidate storage_monitor/MediaDeviceNotificationsUtils into MediaStorageUtil. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix mac apply patch Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/storage_monitor/storage_monitor_mac.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/storage_monitor/volume_mount_watcher_win.cc
diff --git a/chrome/browser/storage_monitor/volume_mount_watcher_win.cc b/chrome/browser/storage_monitor/volume_mount_watcher_win.cc
index 0a76d1122e4233f0787a8c67719a7f4db24d9e36..f300a8e09a3e1f42577ec520f013d972624ca6bc 100644
--- a/chrome/browser/storage_monitor/volume_mount_watcher_win.cc
+++ b/chrome/browser/storage_monitor/volume_mount_watcher_win.cc
@@ -12,7 +12,6 @@
#include "base/string_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/storage_monitor/media_device_notifications_utils.h"
#include "chrome/browser/storage_monitor/media_storage_util.h"
#include "content/public/browser/browser_thread.h"
@@ -263,7 +262,7 @@ void VolumeMountWatcherWin::RetrieveInfoForDeviceAndAdd(
chrome::MediaStorageUtil::Type type =
chrome::MediaStorageUtil::REMOVABLE_MASS_STORAGE_NO_DCIM;
- if (chrome::IsMediaDevice(device_path.value()))
+ if (MediaStorageUtil::HasDcim(device_path.value()))
type = chrome::MediaStorageUtil::REMOVABLE_MASS_STORAGE_WITH_DCIM;
std::string device_id =
chrome::MediaStorageUtil::MakeDeviceId(type, unique_id);
@@ -382,8 +381,9 @@ void VolumeMountWatcherWin::HandleDeviceAttachEventOnUIThread(
return;
if (notifications_) {
- string16 display_name =
- GetDisplayNameForDevice(info.total_size_in_bytes, info.name);
+ string16 display_name = MediaStorageUtil::GetDisplayNameForDevice(
+ info.total_size_in_bytes, info.name);
+
notifications_->ProcessAttach(StorageInfo(info.device_id, display_name,
device_path.value()));
}
« no previous file with comments | « chrome/browser/storage_monitor/storage_monitor_mac.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698