Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5289)

Unified Diff: chrome/browser/storage_monitor/storage_monitor_chromeos.cc

Issue 12544005: Consolidate storage_monitor/MediaDeviceNotificationsUtils into MediaStorageUtil. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix race condition in unit test. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/storage_monitor_chromeos.cc
diff --git a/chrome/browser/storage_monitor/storage_monitor_chromeos.cc b/chrome/browser/storage_monitor/storage_monitor_chromeos.cc
index 44dcf949ac5d9b9e3ca6e9f7ab07a830361bf45c..f07a0cf7914fbf6cb260c3ae684c20fcbe4bfda6 100644
--- a/chrome/browser/storage_monitor/storage_monitor_chromeos.cc
+++ b/chrome/browser/storage_monitor/storage_monitor_chromeos.cc
@@ -12,7 +12,6 @@
#include "base/string_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/utf_string_conversions.h"
-#include "chrome/browser/storage_monitor/media_device_notifications_utils.h"
#include "chrome/browser/storage_monitor/media_storage_util.h"
#include "chrome/browser/storage_monitor/removable_device_constants.h"
#include "content/public/browser/browser_thread.h"
@@ -50,7 +49,8 @@ string16 GetDeviceName(const disks::DiskMountManager::Disk& disk,
if (!device_label.empty() && IsStringUTF8(device_label))
return UTF8ToUTF16(device_label);
- return chrome::GetFullProductName(disk.vendor_name(), disk.product_name());
+ return chrome::MediaStorageUtil::GetFullProductName(disk.vendor_name(),
+ disk.product_name());
}
// Constructs a device id using uuid or manufacturer (vendor and product) id
@@ -101,6 +101,7 @@ bool GetDeviceInfo(const std::string& source_path,
} // namespace
using content::BrowserThread;
+using chrome::StorageInfo;
StorageMonitorCros::StorageMonitorCros() {
DCHECK(disks::DiskMountManager::GetInstance());
@@ -185,7 +186,7 @@ void StorageMonitorCros::OnFormatEvent(
bool StorageMonitorCros::GetStorageInfoForPath(
const base::FilePath& path,
- chrome::StorageInfo* device_info) const {
+ StorageInfo* device_info) const {
if (!path.IsAbsolute())
return false;
@@ -215,7 +216,7 @@ void StorageMonitorCros::CheckMountedPathOnFileThread(
const disks::DiskMountManager::MountPointInfo& mount_info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- bool has_dcim = chrome::IsMediaDevice(mount_info.mount_path);
+ bool has_dcim = chrome::MediaStorageUtil::HasDcim(mount_info.mount_path);
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
@@ -259,9 +260,11 @@ void StorageMonitorCros::AddMountedPathOnUIThread(
std::string device_id = chrome::MediaStorageUtil::MakeDeviceId(type,
unique_id);
+
chrome::StorageInfo object_info(
device_id,
- chrome::GetDisplayNameForDevice(storage_size_in_bytes, device_label),
+ chrome::MediaStorageUtil::GetDisplayNameForDevice(storage_size_in_bytes,
+ device_label),
mount_info.mount_path,
storage_label,
vendor_name,

Powered by Google App Engine
This is Rietveld 408576698