Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 12543034: Move creation of the various WebDatabaseTable types out of WebDatabase. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Jói
Modified:
1 year ago
CC:
chromium-reviews_chromium.org, Raman Kakilate, groby+watch_chromium.org, akalin, estade+watch_chromium.org, benquan, Raghu Simha, rouslan+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, grt+watch_chromium.org, robertshield, Dane Wallinga, dyu1, dhollowa+watch_chromium.org, gbillock+watch_chromium.org, Albert Bodenhamer, haitaol1, smckay+watch_chromium.org, Ilya Sherman, amit, timsteele
Visibility:
Public.

Description

Move creation of the various WebDatabaseTable types out of WebDatabase.

This removes the last of its knowledge of the various table types,
which helps componentize it (see bug).

TBR=robertshield@chromium.org,tim@chromium.org
BUG=181277
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189453

Patch Set 1 #

Patch Set 2 : Fix some tests. #

Patch Set 3 : Self review. #

Total comments: 7

Patch Set 4 : Address review comments. #

Patch Set 5 : Pure merge of LKGR. #

Patch Set 6 : Merge to head for commit. #

Patch Set 7 : Merge on top of issue 12851008 #

Patch Set 8 : del .gitmodules #

Patch Set 9 : Fix clang build. #

Patch Set 10 : Merge to head #

Patch Set 11 : Merge to parent and head. #

Patch Set 12 : Fix Windows release builds (COMDAT folding combined static functions being used for keys. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -741 lines) Lint Patch
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -9 lines 0 comments 0 errors Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 4 chunks +10 lines, -8 lines 0 comments 0 errors Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/webdata/autofill_table.h View 5 2 chunks +8 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/webdata/autofill_table.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +22 lines, -7 lines 0 comments ? errors Download
M chrome/browser/webdata/autofill_table_unittest.cc View 1 2 70 chunks +178 lines, -292 lines 0 comments 0 errors Download
M chrome/browser/webdata/keyword_table.h View 5 2 chunks +8 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/webdata/keyword_table.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +18 lines, -4 lines 0 comments ? errors Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 2 14 chunks +34 lines, -55 lines 0 comments 0 errors Download
M chrome/browser/webdata/logins_table.h View 5 1 chunk +9 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/webdata/logins_table.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +22 lines, -1 line 0 comments 0 errors Download
M chrome/browser/webdata/token_service_table.h View 5 1 chunk +9 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/webdata/token_service_table.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +22 lines, -1 line 0 comments 1 errors Download
M chrome/browser/webdata/token_service_table_unittest.cc View 1 2 1 chunk +22 lines, -24 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_apps_table.h View 5 2 chunks +8 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_apps_table.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +22 lines, -1 line 0 comments 0 errors Download
M chrome/browser/webdata/web_apps_table_unittest.cc View 1 2 5 chunks +19 lines, -18 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_data_service.cc View 1 2 3 4 5 6 21 chunks +38 lines, -34 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_data_service_win.cc View 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database.h View 1 2 3 4 5 6 4 chunks +19 lines, -29 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database.cc View 5 4 chunks +16 lines, -57 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database_migration_unittest.cc View 1 30 chunks +58 lines, -168 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database_service.cc View 1 2 3 4 5 6 7 3 chunks +39 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database_table.h View 1 2 3 5 2 chunks +18 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database_table.cc View 1 chunk +7 lines, -5 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_intents_table.h View 5 2 chunks +7 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_intents_table.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +24 lines, -5 lines 0 comments 0 errors Download
M chrome_frame/test/delete_chrome_history_test.cc View 1 1 chunk +3 lines, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 11
Jói
dhollowa: Main reviewer. caitkp: FYI and for comment. Cheers, Jói
1 year, 1 month ago #1
dhollowa
Great stuff. Overall looks good. Mainly just one implementation question. https://codereview.chromium.org/12543034/diff/4001/chrome/browser/webdata/web_database.h File chrome/browser/webdata/web_database.h (right): https://codereview.chromium.org/12543034/diff/4001/chrome/browser/webdata/web_database.h#newcode76 ...
1 year, 1 month ago #2
Jói
https://codereview.chromium.org/12543034/diff/4001/chrome/browser/webdata/web_database.h File chrome/browser/webdata/web_database.h (right): https://codereview.chromium.org/12543034/diff/4001/chrome/browser/webdata/web_database.h#newcode76 chrome/browser/webdata/web_database.h:76: TableMap tables_; On 2013/03/12 21:29:38, dhollowa wrote: > Did ...
1 year, 1 month ago #3
dhollowa
lgtm https://codereview.chromium.org/12543034/diff/4001/chrome/browser/webdata/web_database.h File chrome/browser/webdata/web_database.h (right): https://codereview.chromium.org/12543034/diff/4001/chrome/browser/webdata/web_database.h#newcode76 chrome/browser/webdata/web_database.h:76: TableMap tables_; On 2013/03/12 21:59:53, Jói wrote: > ...
1 year, 1 month ago #4
Jói
TBR=robertshield@chromium.org for trivial usage update in //chrome_frame. TBR=tim@chromium.org for usage updates in sync. This is ...
1 year, 1 month ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12543034/19001
1 year, 1 month ago #6
I haz the power (commit-bot)
Failed to apply patch for chrome/browser/webdata/autofill_table.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
1 year, 1 month ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12543034/19002
1 year, 1 month ago #8
I haz the power (commit-bot)
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=121489
1 year, 1 month ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12543034/69001
1 year ago #10
I haz the power (commit-bot)
1 year ago #11
Message was sent while issue was closed.
Change committed as 189453
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434