Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 12543010: Establish components/autofill and move some files (Closed)

Created:
7 years, 9 months ago by kaiwang
Modified:
7 years, 9 months ago
Reviewers:
Ilya Sherman, sky, Jói
CC:
chromium-reviews, Raman Kakilate, akalin, Raghu Simha, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, haitaol1, Ilya Sherman, tim (not reviewing), blundell
Visibility:
Public.

Description

Establish components/autofill and move some files Moving autofill related only files under chrome/common/ to components/autofill/common We are going to move autofill to components/autofill to componentize it. This is the first moving CL. BUG=140037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186632

Patch Set 1 #

Patch Set 2 : gyp change #

Patch Set 3 : OWNERS DEPS #

Total comments: 2

Patch Set 4 : fix ios build #

Patch Set 5 : Address comment #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -884 lines) Patch
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/address_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autocheckout_manager.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autocheckout_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autocheckout_page_meta_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autocomplete_history_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autocomplete_history_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_common_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_download_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_field.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_merge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_profile_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_xml_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/credit_card.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/credit_card_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/credit_card_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/form_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/form_structure.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/form_structure_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autofill/name_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/password_autofill_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/password_autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/personal_data_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/phone_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/wallet/wallet_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/wallet/wallet_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_form_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/password_generation_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autofill_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autofill_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 5 chunks +2 lines, -15 lines 0 comments Download
M chrome/common/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/autofill/autocheckout_status.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/common/autofill/web_element_descriptor.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/common/autofill/web_element_descriptor.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/common/autofill_messages.h View 1 chunk +0 lines, -277 lines 0 comments Download
M chrome/common/common_message_generator.h View 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/form_data.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/common/form_data.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/common/form_data_predictions.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/common/form_data_predictions.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/common/form_field_data.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/common/form_field_data.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/common/form_field_data_predictions.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/form_field_data_predictions.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/common/password_form_fill_data.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/common/password_form_fill_data.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/renderer/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/autofill_agent.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/form_cache.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/password_autofill_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_manager_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/password_generation_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/password_generation_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/autofill.gypi View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A components/autofill/DEPS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + components/autofill/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/autofill/common/autocheckout_status.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/common/autofill_messages.h View 1 1 chunk +7 lines, -8 lines 0 comments Download
A + components/autofill/common/form_data.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/autofill/common/form_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/common/form_data_predictions.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/autofill/common/form_data_predictions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/common/form_field_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/common/form_field_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/common/form_field_data_predictions.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/autofill/common/form_field_data_predictions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/common/password_form_fill_data.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/autofill/common/password_form_fill_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/autofill/common/web_element_descriptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/common/web_element_descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jói
I think we may also want to move chrome/renderer/page_click_listener.h|cc, chrome/renderer/page_click_tracker.h|cc, they seem to only be ...
7 years, 9 months ago (2013-03-06 22:02:35 UTC) #1
kaiwang
OWNERs, please review this: joi: components/ isherman: chrome/browser/autofill/ and chrome/renderer/autofill sky: everything else under chrome/ ...
7 years, 9 months ago (2013-03-07 00:01:04 UTC) #2
Jói
LGTM with a nit. I reviewed the whole change. Cheers, Jói https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi File components/autofill.gypi (right): ...
7 years, 9 months ago (2013-03-07 00:13:00 UTC) #3
Ilya Sherman
LGTM2
7 years, 9 months ago (2013-03-07 00:21:36 UTC) #4
sky
LGTM
7 years, 9 months ago (2013-03-07 01:20:45 UTC) #5
kaiwang
https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi File components/autofill.gypi (right): https://codereview.chromium.org/12543010/diff/5001/components/autofill.gypi#newcode1 components/autofill.gypi:1: # Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 9 months ago (2013-03-07 01:26:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12543010/14002
7 years, 9 months ago (2013-03-07 01:39:36 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-03-07 01:40:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/12543010/19001
7 years, 9 months ago (2013-03-07 02:09:26 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-07 05:44:46 UTC) #10
Message was sent while issue was closed.
Change committed as 186632

Powered by Google App Engine
This is Rietveld 408576698