Issue 12542015: Fixed a glitch in the ComponentCloudPolicyUpdater where a protobuf field was read before being vali…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12542015: Fixed a glitch in the ComponentCloudPolicyUpdater where a protobuf field was read before being vali… (Closed)

Created:
7 years, 9 months ago by Joao da Silva

Modified:
7 years, 9 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed a glitch in the ComponentCloudPolicyUpdater where a protobuf field was read before being validated. The updater receives protobufs that contain a secure hash of some content. When this hash differs from the cached version then the content has been updated. The bug is that the updater compares an empty secure_hash with an empty cached hash, which causes an early return but should cancel a pending job, if there is one. BUG=163318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187290

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	chrome/browser/policy/component_cloud_policy_updater.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/policy/component_cloud_policy_updater_unittest.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Here's a simple fix, with a test that fails without the fix. Please review, thanks!

7 years, 9 months ago (2013-03-11 10:32:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/12542015/1

7 years, 9 months ago (2013-03-11 10:43:20 UTC) #3

Message was sent while issue was closed.

Change committed as 187290

Expand Messages | Collapse Messages