Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_private_api.cc

Issue 12537016: Add callback to DiskMountManager::UnmountPath (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
index f16f06670d35d286099d37d5ab3236bb5bea948a..dc2362202ad7fe7787d727270f276d45fb7344e7 100644
--- a/chrome/browser/chromeos/extensions/file_browser_private_api.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
@@ -1657,8 +1657,14 @@ void RemoveMountFunction::GetSelectedFileInfoResponse(
SendResponse(false);
return;
}
- DiskMountManager::GetInstance()->UnmountPath(files[0].local_path.value(),
- chromeos::UNMOUNT_OPTIONS_NONE);
+
+ // TODO(tbarzic): Send response when callback is received, it would make more
+ // sense than remembering issued unmount requests in file manager and showing
+ // errors for them when MountCompleted event is received.
+ DiskMountManager::GetInstance()->UnmountPath(
+ files[0].local_path.value(),
+ chromeos::UNMOUNT_OPTIONS_NONE,
+ DiskMountManager::UnmountPathCallback());
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698