Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 12537007: Don't try to delete directories if sub directories are still part of the client (Closed)

Created:
7 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Don't try to delete directories if sub directories are still part of the client BUG=171212 TEST=ios debug simulator doesn't fail every other run R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=187284

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M gclient.py View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
https://codereview.chromium.org/12537007/diff/1/gclient.py File gclient.py (right): https://codereview.chromium.org/12537007/diff/1/gclient.py#newcode1134 gclient.py:1134: for path in path_list: return any( path[:len(parent_plus_slash)] == parent_plus_slash ...
7 years, 9 months ago (2013-03-08 15:39:40 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/12537007/diff/1/gclient.py File gclient.py (right): https://codereview.chromium.org/12537007/diff/1/gclient.py#newcode1134 gclient.py:1134: for path in path_list: On 2013/03/08 15:39:41, Marc-Antoine Ruel ...
7 years, 9 months ago (2013-03-08 15:51:32 UTC) #2
M-A Ruel
https://codereview.chromium.org/12537007/diff/3/gclient.py File gclient.py (right): https://codereview.chromium.org/12537007/diff/3/gclient.py#newcode1135 gclient.py:1135: path[:len(parent_plus_slash)] == parent_plus_slash as a matter of fact; any(path.startswith(parent ...
7 years, 9 months ago (2013-03-08 15:53:56 UTC) #3
M-A Ruel
7 years, 9 months ago (2013-03-08 15:53:56 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/12537007/diff/3/gclient.py File gclient.py (right): https://codereview.chromium.org/12537007/diff/3/gclient.py#newcode1135 gclient.py:1135: path[:len(parent_plus_slash)] == parent_plus_slash On 2013/03/08 15:53:56, Marc-Antoine Ruel wrote: ...
7 years, 9 months ago (2013-03-11 07:32:10 UTC) #5
M-A Ruel
lgtm
7 years, 9 months ago (2013-03-11 13:04:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12537007/9001
7 years, 9 months ago (2013-03-11 13:04:36 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 13:07:44 UTC) #8
Message was sent while issue was closed.
Change committed as 187284

Powered by Google App Engine
This is Rietveld 408576698