Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 12529014: Android: disables observing changes for font prefs. (Closed)

Created:
7 years, 9 months ago by bulach
Modified:
7 years, 9 months ago
Reviewers:
falken, Bernhard Bauer
CC:
chromium-reviews, jungshik at Google, tony
Visibility:
Public.

Description

Android: disables observing changes for font prefs. On Android, there's no exposed way to change font preferences. This will save ~725KB of heap. BUG=196559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189021

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adds comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bulach
following from the discussion in the bug..
7 years, 9 months ago (2013-03-18 12:23:33 UTC) #1
falken
My feeling is this should be okay, but am a little worried it can cause ...
7 years, 9 months ago (2013-03-18 19:07:37 UTC) #2
Bernhard Bauer
On 2013/03/18 19:07:37, falken wrote: > My feeling is this should be okay, but am ...
7 years, 9 months ago (2013-03-18 19:19:01 UTC) #3
bulach
thanks both! I added some more comments trying to clarify the reasons, please let me ...
7 years, 9 months ago (2013-03-18 19:28:54 UTC) #4
falken
lgtm On 2013/03/18 19:28:54, bulach wrote: > thanks both! I added some more comments trying ...
7 years, 9 months ago (2013-03-18 20:52:48 UTC) #5
bulach
+bauerb for OWNERS :)
7 years, 9 months ago (2013-03-19 09:00:28 UTC) #6
Bernhard Bauer
LGTM
7 years, 9 months ago (2013-03-19 09:50:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12529014/5001
7 years, 9 months ago (2013-03-19 13:28:55 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 15:28:34 UTC) #9
Message was sent while issue was closed.
Change committed as 189021

Powered by Google App Engine
This is Rietveld 408576698