chrome/browser/ui/views/browser_action_view.cc - Issue 12529012: Context menu on views must show on mouse down for non-WIN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_action_view.cc

Issue 12529012: Context menu on views must show on mouse down for non-WIN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: patch Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/browser_action_view.cc

diff --git a/chrome/browser/ui/views/browser_action_view.cc b/chrome/browser/ui/views/browser_action_view.cc

index 7a8a81ef112bd77d42c6ea474a75a621e6945147..05dd725fa2943bce010f65d285ce8e1df938d13c 100644

--- a/chrome/browser/ui/views/browser_action_view.cc

+++ b/chrome/browser/ui/views/browser_action_view.cc

@@ -314,10 +314,12 @@ bool BrowserActionButton::OnMousePressed(const ui::MouseEvent& event) {

TextButton::OnMousePressed(event);

}

- // See comments in MenuButton::Activate() as to why this is needed.

- SetMouseHandler(NULL);

+ if (!views::View::ShouldShowContextMenuOnMousePress()) {

+ // See comments in MenuButton::Activate() as to why this is needed.

+ SetMouseHandler(NULL);

- ShowContextMenu(gfx::Point(), true);

+ ShowContextMenu(gfx::Point(), true);

+ }

return false;

}