Context menu on views must show on mouse down for non-WIN.

ui/views/widget/widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_WIDGET_WIDGET_H_
 #define UI_VIEWS_WIDGET_WIDGET_H_
 
 #include <set>
 #include <stack>
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/observer_list.h"
 #include "ui/base/accessibility/accessibility_types.h"
 #include "ui/base/ui_base_types.h"
 #include "ui/compositor/layer_type.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/rect.h"
 #include "ui/views/focus/focus_manager.h"
 #include "ui/views/widget/native_widget_delegate.h"
+#include "ui/views/widget/widget_observer.h"
 #include "ui/views/window/client_view.h"
 #include "ui/views/window/non_client_view.h"
 
 #if defined(OS_WIN)
 // Windows headers define macros for these function names which screw with us.
 #if defined(IsMaximized)
 #undef IsMaximized
 #endif
 #if defined(IsMinimized)
 #undef IsMinimized
@@ skipping 21 matching lines @@
 namespace views {
 
 class DefaultThemeProvider;
 class DesktopRootWindowHost;
 class InputMethod;
 class NativeWidget;
 class NonClientFrameView;
 class ScopedEvent;
 class View;
 class WidgetDelegate;
-class WidgetObserver;
 
 namespace internal {
 class NativeWidgetPrivate;
 class RootView;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Widget class
 //
 //  Encapsulates the platform-specific rendering, event receiving and widget
@@ skipping 770 matching lines @@
   // Is |root_layers_| out of date?
   bool root_layers_dirty_;
 
   // True when window movement via mouse interaction with the frame should be
   // disabled.
   bool movement_disabled_;
 
   DISALLOW_COPY_AND_ASSIGN(Widget);
 };
 
+// A simple WidgetObserver that can be probed for the life of a widget.
+class WidgetDeletionObserver : public WidgetObserver {

[sky, 2013/04/05 17:23:37]

Move this (and implementation) into its own file.

[varunjain, 2013/04/05 18:01:44]

Done.

+ public:
+  explicit WidgetDeletionObserver(Widget* widget);
+  ~WidgetDeletionObserver();

[sky, 2013/04/05 17:23:37]

virtual

[varunjain, 2013/04/05 18:01:44]

Done.

+
+  // Returns true if the widget passed in the constructor is still alive.
+  bool IsWidgetAlive();

[sky, 2013/04/05 17:23:37]

nit: inline this.

[varunjain, 2013/04/05 18:01:44]

Done.

+
+  // Overridden from WidgetObserver.
+  virtual void OnWidgetDestroying(Widget* widget) OVERRIDE;
+
+ private:
+  void CleanupWidget();
+  Widget* widget_;

[sky, 2013/04/05 17:23:37]

nit: newline between 867/868.

[varunjain, 2013/04/05 18:01:44]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(WidgetDeletionObserver);
+};
+
 }  // namespace views
 
 #endif  // UI_VIEWS_WIDGET_WIDGET_H_