Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12527007: chromeos: Fix malfunctioning CrosDisksClientStubImpl::Unmount (Closed)

Created:
7 years, 9 months ago by hashimoto
Modified:
7 years, 9 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

chromeos: Fix malfunctioning CrosDisksClientStubImpl::Unmount Unmount receives the mounted path, not the source path. BUG=178987 TEST=Mount/Unmount a zip file in Files.app Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186644

Patch Set 1 : _ #

Total comments: 2

Patch Set 2 : rename variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M chromeos/dbus/cros_disks_client.cc View 1 5 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
7 years, 9 months ago (2013-03-06 08:15:30 UTC) #1
satorux1
LGTM https://codereview.chromium.org/12527007/diff/2001/chromeos/dbus/cros_disks_client.cc File chromeos/dbus/cros_disks_client.cc (right): https://codereview.chromium.org/12527007/diff/2001/chromeos/dbus/cros_disks_client.cc#newcode565 chromeos/dbus/cros_disks_client.cc:565: std::map<std::string, std::string> source_paths_; mount_to_source_path_map_ ?
7 years, 9 months ago (2013-03-07 03:18:30 UTC) #2
hashimoto
https://codereview.chromium.org/12527007/diff/2001/chromeos/dbus/cros_disks_client.cc File chromeos/dbus/cros_disks_client.cc (right): https://codereview.chromium.org/12527007/diff/2001/chromeos/dbus/cros_disks_client.cc#newcode565 chromeos/dbus/cros_disks_client.cc:565: std::map<std::string, std::string> source_paths_; On 2013/03/07 03:18:30, satorux1 wrote: > ...
7 years, 9 months ago (2013-03-07 03:31:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/12527007/6001
7 years, 9 months ago (2013-03-07 03:32:29 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-07 06:39:33 UTC) #5
Message was sent while issue was closed.
Change committed as 186644

Powered by Google App Engine
This is Rietveld 408576698