Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: lib/src/chunk.dart

Issue 1252323003: Allow arguments before and after block-formatted functions. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master
Patch Set: Update pubspec and changelog. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/src/argument_list_visitor.dart ('k') | lib/src/rule/argument.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart_style.src.chunk; 5 library dart_style.src.chunk;
6 6
7 import 'fast_hash.dart'; 7 import 'fast_hash.dart';
8 import 'nesting_level.dart'; 8 import 'nesting_level.dart';
9 import 'rule/rule.dart'; 9 import 'rule/rule.dart';
10 10
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 /// Splitting before the first argument when it happens to be a function 286 /// Splitting before the first argument when it happens to be a function
287 /// expression with a block body. 287 /// expression with a block body.
288 static const firstBlockArgument = 2; 288 static const firstBlockArgument = 2;
289 289
290 /// The series of positional arguments. 290 /// The series of positional arguments.
291 static const positionalArguments = 2; 291 static const positionalArguments = 2;
292 292
293 /// Splitting inside the brackets of a list with only one element. 293 /// Splitting inside the brackets of a list with only one element.
294 static const singleElementList = 2; 294 static const singleElementList = 2;
295 295
296 /// Splitting the internals of literal block arguments. 296 /// Splitting the internals of collection literal arguments.
297 /// 297 ///
298 /// Used to prefer splitting at the argument boundary over splitting the 298 /// Used to prefer splitting at the argument boundary over splitting the
299 /// block contents. 299 /// collection contents.
300 static const splitBlocks = 2; 300 static const splitCollections = 2;
301 301
302 /// Splitting before a type argument or type parameter. 302 /// Splitting before a type argument or type parameter.
303 static const typeArgument = 4; 303 static const typeArgument = 4;
304 } 304 }
305 305
306 /// The in-progress state for a [Span] that has been started but has not yet 306 /// The in-progress state for a [Span] that has been started but has not yet
307 /// been completed. 307 /// been completed.
308 class OpenSpan { 308 class OpenSpan {
309 /// Index of the first chunk contained in this span. 309 /// Index of the first chunk contained in this span.
310 int get start => _start; 310 int get start => _start;
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 /// output. This way, commented out chunks of code do not get erroneously 359 /// output. This way, commented out chunks of code do not get erroneously
360 /// re-indented. 360 /// re-indented.
361 final bool flushLeft; 361 final bool flushLeft;
362 362
363 /// Whether this comment is an inline block comment. 363 /// Whether this comment is an inline block comment.
364 bool get isInline => linesBefore == 0 && !isLineComment; 364 bool get isInline => linesBefore == 0 && !isLineComment;
365 365
366 SourceComment(this.text, this.linesBefore, 366 SourceComment(this.text, this.linesBefore,
367 {this.isLineComment, this.flushLeft}); 367 {this.isLineComment, this.flushLeft});
368 } 368 }
OLDNEW
« no previous file with comments | « lib/src/argument_list_visitor.dart ('k') | lib/src/rule/argument.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698