chrome/common/extensions/docs/server2/server_instance.py - Issue 12521030: Extension docs: Include sidenav in 404 pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/server_instance.py

Issue 12521030: Extension docs: Include sidenav in 404 pages (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/render_servlet.py ('k') | chrome/common/extensions/docs/server2/sidenav_data_source.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/server_instance.py

===================================================================

--- chrome/common/extensions/docs/server2/server_instance.py (revision 202781)

+++ chrome/common/extensions/docs/server2/server_instance.py (working copy)

@@ -40,7 +40,7 @@

object_store_creator,

host_file_system,

app_samples_file_system,

- static_path,

+ base_path,

compiled_fs_factory):

self.channel = channel

@@ -95,7 +95,8 @@

self.sidenav_data_source_factory = SidenavDataSource.Factory(

self.compiled_host_fs_factory,

- svn_constants.JSON_PATH)

+ svn_constants.JSON_PATH,

+ base_path)

self.template_data_source_factory = TemplateDataSource.Factory(

channel,

@@ -108,7 +109,7 @@

self.ref_resolver_factory,

svn_constants.PUBLIC_TEMPLATE_PATH,

svn_constants.PRIVATE_TEMPLATE_PATH,

- static_path)

+ base_path)

self.example_zipper = ExampleZipper(

self.compiled_host_fs_factory,

@@ -128,7 +129,7 @@

object_store_creator,

file_system,

EmptyDirFileSystem(),

- '/static',

+ '',

CompiledFileSystem.Factory(file_system,

object_store_creator))

@@ -145,5 +146,5 @@

object_store_creator,

file_system,

EmptyDirFileSystem(),

- '/static',

+ '',

CompiledFileSystem.Factory(file_system, object_store_creator))