Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2722)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/docs/server2/server_instance.py

Issue 12521030: Extension docs: Include sidenav in 404 pages (Closed) Base URL: https://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/server2/integration_test.py ('k') | chrome/common/extensions/docs/server2/url_constants.py » ('j') | chrome/common/extensions/docs/templates/articles/404.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/server_instance.py
===================================================================
--- chrome/common/extensions/docs/server2/server_instance.py (revision 190643)
+++ chrome/common/extensions/docs/server2/server_instance.py (working copy)
@@ -71,5 +71,9 @@
response.headers['cache-control'] = 'max-age=300'
response.out.write(content)
else:
- response.set_status(404);
- response.out.write(templates.Render('404'))
+ response.set_status(404)
+ doc_class = path.split('/', 1)[0]
+ content = templates.Render(doc_class + '/404')
+ if not content:
+ content = templates.Render('extensions/404')
+ response.out.write(content)
« no previous file with comments | « chrome/common/extensions/docs/server2/integration_test.py ('k') | chrome/common/extensions/docs/server2/url_constants.py » ('j') | chrome/common/extensions/docs/templates/articles/404.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698