Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4301)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/docs/server2/render_servlet.py

Issue 12521030: Extension docs: Include sidenav in 404 pages (Closed) Base URL: https://src.chromium.org/svn/trunk/src/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/server2/patch_servlet_test.py ('k') | chrome/common/extensions/docs/server2/server_instance.py » ('j') | chrome/common/extensions/docs/server2/sidenav_data_source.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/render_servlet.py
===================================================================
--- chrome/common/extensions/docs/server2/render_servlet.py (revision 201930)
+++ chrome/common/extensions/docs/server2/render_servlet.py (working copy)
@@ -90,7 +90,13 @@
headers = {'x-frame-options': 'sameorigin'}
if content is None:
- return Response.NotFound(templates.Render('404'), headers=headers)
+ doc_class = path.split('/', 1)[0]
+ content = templates.Render('%s/404' % doc_class)
+ if not content:
+ content = templates.Render('extensions/404')
+ if content is None:
+ content = 'Not Found.'
not at google - send to devlin 2013/05/28 23:45:27 we agreed to remove this last check?
+ return Response.NotFound(content, headers=headers)
if not content:
logging.error('%s had empty content' % path)
« no previous file with comments | « chrome/common/extensions/docs/server2/patch_servlet_test.py ('k') | chrome/common/extensions/docs/server2/server_instance.py » ('j') | chrome/common/extensions/docs/server2/sidenav_data_source.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698