Extension docs: Include sidenav in 404 pages

chrome/common/extensions/docs/server2/server_instance.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from fnmatch import fnmatch
 import mimetypes
 import os
 
 from file_system import FileNotFoundError
 import compiled_file_system as compiled_fs
@@ skipping 54 matching lines @@
       content = self._FetchStaticResource(path, response)
     elif path.endswith('.html'):
       content = templates.Render(path)
 
     response.headers['x-frame-options'] = 'sameorigin'
     if content:
       response.headers['cache-control'] = 'max-age=300'
       response.out.write(content)
     else:
       response.set_status(404);
-      response.out.write(templates.Render('404'))
+      if path.startswith('apps/'):
+        response.out.write(templates.Render('apps/404'))
+      else:
+        response.out.write(templates.Render('extensions/404'))

[not at google - send to devlin, 2013/03/26 16:12:19]

As a somewhat separate issue, we need to move away from having just an apps and
an extensions mode for the server, since there's a good chance we're going to
start supporting more classes.

There will be plenty of other work needed to support this - but I don't want to
cause unnecessary friction here.

You should be able to list the files in the directory containing the broken link
via _cache.GetFromFileListing, then step up the hierarchy until a 404 file is
found.

[方觉(Fang Jue), 2013/03/27 00:43:46]

I tried to extract the first component of path and treat it as doc class. Then
try to render the 404 page of that class. If it fails, render extensions/404. Is
that ok?

On 2013/03/26 16:12:19, kalman wrote: