chrome/common/extensions/docs/templates/private/header_head.html - Issue 12521030: Extension docs: Include sidenav in 404 pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/header_head.html

Issue 12521030: Extension docs: Include sidenav in 404 pages (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/templates/articles/404.html ('K') | « chrome/common/extensions/docs/templates/articles/404.html ('k') | chrome/common/extensions/docs/templates/private/standard_apps_article.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />	1 <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

2 <link href="{{static}}/css/site.css" rel="stylesheet" type="text/css">	2 <link href="{{static}}/css/site.css" rel="stylesheet" type="text/css">

3 <link href="{{static}}/css/print.css" rel="stylesheet" type="text/css" media="pr int">	3 <link href="{{static}}/css/print.css" rel="stylesheet" type="text/css" media="pr int">

4 <link href="{{static}}/css/prettify.css" rel="stylesheet" type="text/css">	4 <link href="{{static}}/css/prettify.css" rel="stylesheet" type="text/css">

5 <link href="//www.google.com/images/icons/product/chrome-16.png" rel="icon" type ="image/ico">	5 <link href="//www.google.com/images/icons/product/chrome-16.png" rel="icon" type ="image/ico">

6 <link href='//fonts.googleapis.com/css?family=Open+Sans:400,700' rel='stylesheet ' type='text/css'>	6 <link href='//fonts.googleapis.com/css?family=Open+Sans:400,700' rel='stylesheet ' type='text/css'>

	7 {{?is_404}}
	not at google - send to devlin 2013/03/27 03:52:36 I really don't want to add logic like this into sh I really don't want to add logic like this into shared files. Or any files really.
	8 <base href="/{{branchInfo.current}}/{{platform}}s/">
	not at google - send to devlin 2013/03/27 03:52:36 I see. Yeah, there are a lot of assumptions everyw I see. Yeah, there are a lot of assumptions everywhere that we're dealing with paths that look like either /foo or /extensions/foo. This particular issue will have to wait a little while to fix globally until we don't need to deal with the differences between dev/beta/trunk (coming soon), but that's beside the point... Anyway, my preferred way to fix this is to make the sidebar generate correct absolute paths. See templates/private/sidenav_item.html, line 9.
	9 <style type="text/css">

	10 #gc-sidebar.floating {

	11 position: relative;
	not at google - send to devlin 2013/03/27 03:52:36 right, but you can still scroll the sidebar itself right, but you can still scroll the sidebar itself. I agree that it does look a bit bad, though. We're better off fixing this with more javascript though, in chrome/common/extensions/docs/static/js/scroll.js itself, by comparing the height of the sidebar to the window height and applying position:relative rather than fixed if it's bigger. But that can be a separate change.
	12 }

	13 </style>

	14 {{/is_404}}

OLD	NEW