Issue 12521007: Cleanup the copying of ICs to the Megamorphic Code Cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12521007: Cleanup the copying of ICs to the Megamorphic Code Cache (Closed)

Created:
7 years, 9 months ago by Toon Verwaest

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleanup the copying of ICs to the Megamorphic Code Cache Committed: https://code.google.com/p/v8/source/detail?r=13907

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -28 lines)			Patch
	M	src/ic.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/ic.cc	View		3 chunks	+22 lines, -28 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. https://chromiumcodereview.appspot.com/12521007/diff/1/src/ic.cc File src/ic.cc (right): https://chromiumcodereview.appspot.com/12521007/diff/1/src/ic.cc#newcode1055 src/ic.cc:1055: UpdateMegamorphicCache(map, *name, target()); You can s/target()/handler/ ...

7 years, 9 months ago (2013-03-07 11:26:40 UTC) #2

Toon Verwaest

addressed nit. landing. https://chromiumcodereview.appspot.com/12521007/diff/1/src/ic.cc File src/ic.cc (right): https://chromiumcodereview.appspot.com/12521007/diff/1/src/ic.cc#newcode1055 src/ic.cc:1055: UpdateMegamorphicCache(map, *name, target()); On 2013/03/07 11:26:40, ...

7 years, 9 months ago (2013-03-11 15:11:19 UTC) #3

Toon Verwaest

7 years, 9 months ago (2013-03-11 15:11:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r13907 (presubmit successful).

Expand Messages | Collapse Messages