Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1926)

Issue 12520005: Move desktop-specific Instant bits to c/b/ui/search. (Closed)

Created:
7 years, 9 months ago by samarth
Modified:
7 years, 9 months ago
Reviewers:
sky, sreeram, dhollowa
CC:
chromium-reviews, melevin, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, sreeram, sail+watch_chromium.org, gideonwald, dominich, David Black, samarth+watch_chromium.org, tfarina, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move desktop-specific Instant bits to c/b/ui/search. This is part 2 of the cleanup described in the attached bug. Also, added sreeram to c/b/ui/search/OWNERS and dhollowa to c/b/instant/OWNERS. BUG=179184 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188656

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase. Restore OWNERS change. #

Patch Set 4 : P comes before S #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -6850 lines) Patch
M chrome/browser/history/DEPS View 1 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobar_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/OWNERS View 2 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/instant/instant_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1015 lines 0 comments Download
D chrome/browser/instant/instant_commit_type.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/instant/instant_controller.h View 1 2 3 4 5 1 chunk +0 lines, -468 lines 0 comments Download
D chrome/browser/instant/instant_controller.cc View 1 2 3 4 5 1 chunk +0 lines, -1582 lines 0 comments Download
D chrome/browser/instant/instant_extended_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1258 lines 0 comments Download
D chrome/browser/instant/instant_extended_manual_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -312 lines 0 comments Download
D chrome/browser/instant/instant_loader.h View 1 2 3 4 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/instant/instant_loader.cc View 1 2 3 4 1 chunk +0 lines, -236 lines 0 comments Download
D chrome/browser/instant/instant_ntp.h View 1 2 3 4 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/instant/instant_ntp.cc View 1 2 3 4 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/instant/instant_overlay.h View 1 2 3 4 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/browser/instant/instant_overlay.cc View 1 2 3 4 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/browser/instant/instant_overlay_controller.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/instant/instant_overlay_controller.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/instant/instant_overlay_model.h View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/instant/instant_overlay_model.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/instant/instant_overlay_model_observer.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/instant/instant_page.h View 1 2 3 4 5 1 chunk +0 lines, -239 lines 0 comments Download
D chrome/browser/instant/instant_page.cc View 1 2 3 4 5 1 chunk +0 lines, -282 lines 0 comments Download
D chrome/browser/instant/instant_tab.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/instant/instant_tab.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/instant/instant_test_utils.h View 1 2 3 4 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/instant/instant_test_utils.cc View 1 2 3 4 1 chunk +0 lines, -197 lines 0 comments Download
D chrome/browser/instant/instant_unload_handler.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/instant/instant_unload_handler.cc View 1 chunk +0 lines, -106 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/instant_overlay_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/instant_overlay_controller_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/OWNERS View 2 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/ui/search/instant_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/search/instant_commit_type.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_controller.h View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/ui/search/instant_controller.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/search/instant_extended_browsertest.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/search/instant_extended_manual_browsertest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/search/instant_loader.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_loader.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_ntp.h View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/search/instant_ntp.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_overlay.h View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/ui/search/instant_overlay.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_overlay_controller.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/search/instant_overlay_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_overlay_model.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_overlay_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_overlay_model_observer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_page.h View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_page.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_tab.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/search/instant_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_test_utils.h View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/search/instant_test_utils.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/search/instant_unload_handler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/search/instant_unload_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/instant_overlay_controller_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/instant_overlay_controller_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/instant_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
samarth
Hi Sreeram, David, Scott, Here's the second part of the cleanup. Per discussion with David, ...
7 years, 9 months ago (2013-03-08 20:05:22 UTC) #1
sky
Don't forget to update all the header guards.
7 years, 9 months ago (2013-03-08 21:49:45 UTC) #2
tfarina
I think that is what ./tools/git/move_source_file.py is for (Joi added).
7 years, 9 months ago (2013-03-08 21:52:23 UTC) #3
samarth
Ah, that's even better, thanks! Done. Samarth
7 years, 9 months ago (2013-03-11 17:04:17 UTC) #4
dhollowa
lgtm
7 years, 9 months ago (2013-03-11 17:29:32 UTC) #5
sreeram
rubber stamp LGTM
7 years, 9 months ago (2013-03-13 18:24:00 UTC) #6
sreeram
The OWNERS file changes seem to have been dropped, though.
7 years, 9 months ago (2013-03-13 18:26:00 UTC) #7
samarth
Oops, restored the OWNERS file changes. sky: PTAL. Thanks! Samarth
7 years, 9 months ago (2013-03-13 23:44:41 UTC) #8
sky
Rubber stamp LGTM
7 years, 9 months ago (2013-03-14 00:12:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samarth@chromium.org/12520005/31001
7 years, 9 months ago (2013-03-15 23:03:11 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-16 00:17:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samarth@chromium.org/12520005/57001
7 years, 9 months ago (2013-03-17 20:48:26 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-17 22:44:50 UTC) #13
Message was sent while issue was closed.
Change committed as 188656

Powered by Google App Engine
This is Rietveld 408576698