Issue 12518017: Generalize migration code in WebDatabase.

Issue 12518017: Generalize migration code in WebDatabase. (Closed)

Created:
7 years, 9 months ago by Jói

Modified:
7 years, 9 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, Raman Kakilate, groby+watch_chromium.org, benquan, dhollowa+watch_chromium.org, rouslan+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, gbillock+watch_chromium.org, estade+watch_chromium.org, smckay+watch_chromium.org, Ilya Sherman, Cait (Slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Generalize migration code in WebDatabase. This is part of removing knowledge of individual table types from WebDatabase, which is part of splitting WebData into several components (one component for generic bits like WebDatabase and whatever we end up calling the base class for all XyzWebData classes, e.g. AutofillWebData, plus one component per data type). BUG=181277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187663

Patch Set 1 #

Patch Set 2 : Merge to parent. #

Total comments: 2

Patch Set 3 : Address review nit. #

Patch Set 4 : Pure merge of LKGR #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -227 lines)			Patch
M	chrome/browser/webdata/autofill_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/autofill_table.cc	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/keyword_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/keyword_table.cc	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/logins_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/logins_table.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/token_service_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/token_service_table.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_apps_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_apps_table.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_database.h	View		3 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View		3 chunks	+64 lines, -220 lines	0 comments	Download
M	chrome/browser/webdata/web_database_table.h	View	1 2	2 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/web_intents_table.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dhollowa

lgtm https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h File chrome/browser/webdata/web_database_table.h (right): https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h#newcode39 chrome/browser/webdata/web_database_table.h:39: // the compatible version should be changed to ...

7 years, 9 months ago (2013-03-12 01:38:15 UTC) #2

Jói

https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h File chrome/browser/webdata/web_database_table.h (right): https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h#newcode39 chrome/browser/webdata/web_database_table.h:39: // the compatible version should be changed to On ...

7 years, 9 months ago (2013-03-12 02:00:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12518017/1017

7 years, 9 months ago (2013-03-12 14:40:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12518017/31001

7 years, 9 months ago (2013-03-12 17:04:57 UTC) #5

Message was sent while issue was closed.

Change committed as 187663

Expand Messages | Collapse Messages