Chromium Code Reviews
Help | Chromium Project | Sign in
(989)

Issue 12518017: Generalize migration code in WebDatabase. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Jói
Modified:
1 year, 1 month ago
Reviewers:
dhollowa
CC:
chromium-reviews_chromium.org, Raman Kakilate, groby+watch_chromium.org, benquan, dhollowa+watch_chromium.org, rouslan+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, gbillock+watch_chromium.org, estade+watch_chromium.org, smckay+watch_chromium.org, Ilya Sherman, Cait Phillips
Visibility:
Public.

Description

Generalize migration code in WebDatabase.

This is part of removing knowledge of individual table types from
WebDatabase, which is part of splitting WebData into several
components (one component for generic bits like WebDatabase and
whatever we end up calling the base class for all XyzWebData classes,
e.g. AutofillWebData, plus one component per data type).

BUG=181277
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187663

Patch Set 1 #

Patch Set 2 : Merge to parent. #

Total comments: 2

Patch Set 3 : Address review nit. #

Patch Set 4 : Pure merge of LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -227 lines) Lint Patch
M chrome/browser/webdata/autofill_table.h View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/autofill_table.cc View 1 chunk +46 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/keyword_table.h View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/keyword_table.cc View 1 chunk +46 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/logins_table.h View 1 chunk +3 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/webdata/logins_table.cc View 1 chunk +6 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/webdata/token_service_table.h View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/token_service_table.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_apps_table.h View 1 chunk +3 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/webdata/web_apps_table.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database.h View 3 chunks +15 lines, -6 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database.cc View 3 chunks +64 lines, -220 lines 0 comments 0 errors Download
M chrome/browser/webdata/web_database_table.h View 1 2 2 chunks +15 lines, -1 line 0 comments 1 errors Download
M chrome/browser/webdata/web_intents_table.h View 1 chunk +3 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/webdata/web_intents_table.cc View 1 chunk +11 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 6
Jói
1 year, 1 month ago #1
dhollowa
lgtm https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h File chrome/browser/webdata/web_database_table.h (right): https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h#newcode39 chrome/browser/webdata/web_database_table.h:39: // the compatible version should be changed to ...
1 year, 1 month ago #2
Jói
https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h File chrome/browser/webdata/web_database_table.h (right): https://codereview.chromium.org/12518017/diff/3001/chrome/browser/webdata/web_database_table.h#newcode39 chrome/browser/webdata/web_database_table.h:39: // the compatible version should be changed to On ...
1 year, 1 month ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12518017/1017
1 year, 1 month ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12518017/31001
1 year, 1 month ago #5
I haz the power (commit-bot)
1 year, 1 month ago #6
Message was sent while issue was closed.
Change committed as 187663
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6