Issue 12516019: Make process_resources.py more configurable

Issue 12516019: Make process_resources.py more configurable (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
Yaron, newt (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make process_resources.py more configurable This allows more configuration of the aapt call from within gyp. This is primarily to support differences that are required to use process_resources.py for java_apk.gypi. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190055

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Add back single quotes #

Patch Set 4 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -28 lines)			Patch
	M	build/android/process_resources.py	View		7 chunks	+16 lines, -9 lines	0 comments	Download
	M	build/java.gypi	View	1 2	4 chunks	+26 lines, -19 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

newt (away)

lgtm https://codereview.chromium.org/12516019/diff/2001/build/android/process_resources.py File build/android/process_resources.py (left): https://codereview.chromium.org/12516019/diff/2001/build/android/process_resources.py#oldcode54 build/android/process_resources.py:54: dummy_manifest = os.path.join(BUILD_ANDROID_DIR, 'AndroidManifest.xml') can we get rid ...

7 years, 9 months ago (2013-03-19 21:40:23 UTC) #2

newt (away)

https://codereview.chromium.org/12516019/diff/2001/build/java.gypi File build/java.gypi (right): https://codereview.chromium.org/12516019/diff/2001/build/java.gypi#newcode192 build/java.gypi:192: '--ignore=>!(echo >(_inputs) | md5sum)', Actually, looks like torne added ...

7 years, 9 months ago (2013-03-20 20:21:26 UTC) #3