Issue 12513011: Telemetry / Android: further cleanup on surface_stats_collector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12513011: Telemetry / Android: further cleanup on surface_stats_collector. (Closed)

Created:
7 years, 9 months ago by bulach

Modified:
7 years, 9 months ago

Reviewers:
Sami

CC:
chromium-reviews, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry / Android: further cleanup on surface_stats_collector. - Use a "Start / Stop" method rather than __enter__ / __exit__ - Make "trace_tag" optional - Remove printing results. Note: N-sided patch, further cleanup to remove the constructor param and the __enter__ / __exit__ methods will be done once this rolls. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188167

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -18 lines)			Patch
	M	build/android/pylib/surface_stats_collector.py	View		3 chunks	+7 lines, -14 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/chrome/android_platform_backend.py	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12513011/1

7 years, 9 months ago (2013-03-14 13:22:06 UTC) #3

Message was sent while issue was closed.

Change committed as 188167

Expand Messages | Collapse Messages