Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 12512014: Fix window positioning in high-DPI on Windows. (Closed)

Created:
7 years, 9 months ago by kevers
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix window positioning in high-DPI on Windows. BUG=149881 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192750

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix merge conflicts. #

Patch Set 3 : Fix another merge conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -15 lines) Patch
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 7 chunks +28 lines, -12 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kevers
Oshima-san, Can you please have a look at this CL. Cleans up many of the ...
7 years, 9 months ago (2013-03-20 19:06:51 UTC) #1
oshima
I'm not familiar with desktop aura/win. ben should review this. https://codereview.chromium.org/12512014/diff/1/ui/views/widget/desktop_aura/desktop_screen_position_client.cc File ui/views/widget/desktop_aura/desktop_screen_position_client.cc (right): https://codereview.chromium.org/12512014/diff/1/ui/views/widget/desktop_aura/desktop_screen_position_client.cc#newcode19 ...
7 years, 9 months ago (2013-03-21 00:31:55 UTC) #2
oshima
I'm not familiar with desktop aura/win. ben should review this.
7 years, 9 months ago (2013-03-21 00:31:56 UTC) #3
oshima
I'm not familiar with desktop aura/win. ben should review this.
7 years, 9 months ago (2013-03-21 00:31:57 UTC) #4
kevers
https://codereview.chromium.org/12512014/diff/1/ui/views/widget/desktop_aura/desktop_screen_position_client.cc File ui/views/widget/desktop_aura/desktop_screen_position_client.cc (right): https://codereview.chromium.org/12512014/diff/1/ui/views/widget/desktop_aura/desktop_screen_position_client.cc#newcode19 ui/views/widget/desktop_aura/desktop_screen_position_client.cc:19: float scale = gfx::Screen::GetScreenFor(window)-> On 2013/03/21 00:31:55, oshima wrote: ...
7 years, 9 months ago (2013-03-21 13:37:25 UTC) #5
Ben Goodger (Google)
win lgtm
7 years, 9 months ago (2013-03-22 15:42:51 UTC) #6
oshima
https://codereview.chromium.org/12512014/diff/1/ui/views/widget/desktop_aura/desktop_screen_position_client.cc File ui/views/widget/desktop_aura/desktop_screen_position_client.cc (right): https://codereview.chromium.org/12512014/diff/1/ui/views/widget/desktop_aura/desktop_screen_position_client.cc#newcode19 ui/views/widget/desktop_aura/desktop_screen_position_client.cc:19: float scale = gfx::Screen::GetScreenFor(window)-> On 2013/03/21 13:37:26, kevers wrote: ...
7 years, 9 months ago (2013-03-23 04:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12512014/10001
7 years, 8 months ago (2013-04-05 18:09:06 UTC) #8
commit-bot: I haz the power
Failed to apply patch for ui/views/widget/desktop_aura/desktop_root_window_host_win.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-05 18:09:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12512014/14003
7 years, 8 months ago (2013-04-05 19:47:19 UTC) #10
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=26649
7 years, 8 months ago (2013-04-05 22:40:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12512014/14003
7 years, 8 months ago (2013-04-06 10:42:07 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-04-06 15:55:08 UTC) #13
Message was sent while issue was closed.
Change committed as 192750

Powered by Google App Engine
This is Rietveld 408576698