Issue 12510006: Fix crash in OmniboxEditModel::OpenMatch()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12510006: Fix crash in OmniboxEditModel::OpenMatch() (Closed)

Created:
7 years, 9 months ago by Mark P

Modified:
7 years, 9 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash in OmniboxEditModel::OpenMatch() BUG=142931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186931

Patch Set 1 #

Patch Set 2 : fix parens #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/omnibox/omnibox_edit_model.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/12510006/2001

7 years, 9 months ago (2013-03-08 01:00:13 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=17598

7 years, 9 months ago (2013-03-08 04:59:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/12510006/2001

7 years, 9 months ago (2013-03-08 05:16:24 UTC) #5

Message was sent while issue was closed.

Change committed as 186931

Expand Messages | Collapse Messages