Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 12507010: Turn Flags into a uint32_t typedef. (Closed)

Created:
7 years, 9 months ago by Toon Verwaest
Modified:
7 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Turn Flags into a uint32_t typedef. We cannot rely on C++ compilers inferring the int-type from the enum value range. Whereas Linux/OSX find uint32_t as type for [0,MaxUInt32], Windows insists it's int. Update the test to execute its original intent on all platforms: 1 value larger than max arguments, 1 smaller than max arguments (on all platforms). This makes the test run a lot faster. BUG=chromium:194749 Committed: https://code.google.com/p/v8/source/detail?r=13988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/objects.h View 1 chunk +1 line, -6 lines 0 comments Download
M test/mjsunit/regress/regress-1122.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 9 months ago (2013-03-19 13:07:29 UTC) #1
Jakob Kummerow
lgtm
7 years, 9 months ago (2013-03-19 13:08:56 UTC) #2
Toon Verwaest
7 years, 9 months ago (2013-03-19 13:11:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698