signin: pull basic SigninManager functionality into new SigninManagerBase class.

chrome/browser/signin/signin_tracker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_tracker.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 52 matching lines @@
     profile_.reset(ProfileSyncServiceMock::MakeSignedInTestingProfile());
     mock_token_service_ = static_cast<MockTokenService*>(
         TokenServiceFactory::GetInstance()->SetTestingFactoryAndUse(
             profile_.get(), BuildMockTokenService));
     mock_pss_ = static_cast<ProfileSyncServiceMock*>(
         ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
             profile_.get(),
             ProfileSyncServiceMock::BuildMockProfileSyncService));
     mock_pss_->Initialize();
 
-    mock_signin_manager_ = static_cast<FakeSigninManager*>(
+    mock_signin_manager_ = static_cast<FakeSigninManagerBase*>(
         SigninManagerFactory::GetInstance()->SetTestingFactoryAndUse(
-            profile_.get(), FakeSigninManager::Build));
+            profile_.get(), FakeSigninManagerBase::Build));
 
     // Make gmock not spam the output with information about these uninteresting
     // calls.
     EXPECT_CALL(*mock_pss_, AddObserver(_)).Times(AnyNumber());
     EXPECT_CALL(*mock_pss_, RemoveObserver(_)).Times(AnyNumber());
     tracker_.reset(new SigninTracker(profile_.get(), &observer_));
   }
   virtual void TearDown() OVERRIDE {
     tracker_.reset();
     profile_.reset();
   }
   scoped_ptr<SigninTracker> tracker_;
   scoped_ptr<TestingProfile> profile_;
   ProfileSyncServiceMock* mock_pss_;
-  FakeSigninManager* mock_signin_manager_;
+  FakeSigninManagerBase* mock_signin_manager_;
   MockTokenService* mock_token_service_;
   MockObserver observer_;
 };
 
 TEST_F(SigninTrackerTest, GaiaSignInFailed) {
   // SIGNIN_FAILED notification should result in a SigninFailed callback.
   GoogleServiceAuthError error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   EXPECT_CALL(observer_, SigninFailed(error));
   content::NotificationService::current()->Notify(
@@ skipping 36 matching lines @@
 
 }
 
 TEST_F(SigninTrackerTest, GaiaSigninWhenServicesAlreadyRunning) {
   // SIGNIN_SUCCEEDED notification should result in a SigninSuccess() callback
   // if we're already signed in.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(observer_, SigninSuccess());
   GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
   ExpectSignedInSyncService(mock_pss_, mock_token_service_, error);
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
 }
 
 TEST_F(SigninTrackerTest, NoGaiaSigninWhenOAuthTokensNotAvailable) {
   // SIGNIN_SUCCESSFUL notification should not result in a SigninSuccess()
   // callback if our oauth token hasn't been fetched.
@@ skipping 18 matching lines @@
   // callback until after our oauth token hasn't been fetched.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   GoogleServiceAuthError none(GoogleServiceAuthError::NONE);
   ExpectSignedInSyncService(mock_pss_, NULL, none);
   EXPECT_CALL(*mock_token_service_,
               HasTokenForService(GaiaConstants::kSyncService))
       .WillRepeatedly(Return(true));
   EXPECT_CALL(*mock_token_service_,
               HasTokenForService(GaiaConstants::kGaiaOAuth2LoginRefreshToken))
       .WillRepeatedly(Return(false));
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
   Mock::VerifyAndClearExpectations(mock_pss_);
   Mock::VerifyAndClearExpectations(mock_token_service_);
   EXPECT_CALL(observer_, SigninSuccess());
   ExpectSignedInSyncService(mock_pss_, mock_token_service_, none);
   TokenService::TokenAvailableDetails available(
@@ skipping 50 matching lines @@
 }
 
 TEST_F(SigninTrackerTest, GaiaSigninAfterSyncStarts) {
   // Make sure that we don't get a SigninSuccess() callback until after the
   // sync service reports that it's signed in.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillOnce(
       Return(false));
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
   Mock::VerifyAndClearExpectations(mock_pss_);
   // Mimic the sync engine getting credentials.
   EXPECT_CALL(observer_, SigninSuccess());
   GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
   ExpectSignedInSyncService(mock_pss_, mock_token_service_, error);
   tracker_->OnStateChanged();
 }
 
 TEST_F(SigninTrackerTest, SyncSigninError) {
   // Make sure that we get a SigninFailed() callback if sync gets an error after
   // initializaiton.
   EXPECT_CALL(observer_, GaiaCredentialsValid());
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceSigninSuccessDetails details("username@gmail.com", "password");
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL,
       content::Source<Profile>(profile_.get()),
       content::Details<const GoogleServiceSigninSuccessDetails>(&details));
 
   // Still waiting for auth, so sync state changes should be ignored.
   EXPECT_CALL(*mock_pss_, waiting_for_auth()).WillOnce(Return(true));
   tracker_->OnStateChanged();
   // Now mimic an auth error - this should cause us to fail (not waiting for
   // auth, but still have no credentials).
   GoogleServiceAuthError error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   FakeAuthStatusProvider provider(mock_signin_manager_->signin_global_error());
   provider.SetAuthError(error);
   EXPECT_CALL(*mock_pss_, waiting_for_auth()).WillRepeatedly(Return(false));
   EXPECT_CALL(observer_, SigninFailed(error));
   tracker_->OnStateChanged();
 }
 
 // Test cases for initial state = SERVICES_INITIALIZING.
 TEST_F(SigninTrackerTest, SigninSuccess) {
   // Reset the |tracker_| and restart with initial state parameter for its
   // constructor later.
   tracker_.reset();
   GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
   ExpectSignedInSyncService(mock_pss_, mock_token_service_, error);
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
+
   // Finally SigninSuccess() is expected to be called when everything is ready.
   EXPECT_CALL(observer_, SigninSuccess());
   tracker_.reset(new SigninTracker(profile_.get(), &observer_,
                                    SigninTracker::SERVICES_INITIALIZING));
 }
 
 TEST_F(SigninTrackerTest, SigninFailedSyncTokenUnavailable) {
   tracker_.reset();
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   GoogleServiceAuthError error(GoogleServiceAuthError::NONE);
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
       Return(true));
   // Inject Token unavailable error.
   EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_pss_, waiting_for_auth()).WillRepeatedly(Return(false));
   EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(error));
   EXPECT_CALL(*mock_pss_, HasUnrecoverableError()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_pss_, sync_initialized()).WillRepeatedly(Return(true));
   // Any error should result in SigninFailed() being called.
   EXPECT_CALL(observer_, SigninFailed(error));
   tracker_.reset(new SigninTracker(profile_.get(), &observer_,
                                    SigninTracker::SERVICES_INITIALIZING));
 }
 
 TEST_F(SigninTrackerTest, SigninFailedGoogleServiceAuthError) {
   tracker_.reset();
   EXPECT_CALL(*mock_token_service_, HasTokenForService(_))
       .WillRepeatedly(Return(true));
-  mock_signin_manager_->StartSignInWithCredentials("0", "username@gmail.com",
-                                                   "password");
+  mock_signin_manager_->SetAuthenticatedUsername("username@gmail.com");
   // Inject authentication error.
   GoogleServiceAuthError error(GoogleServiceAuthError::SERVICE_UNAVAILABLE);
   FakeAuthStatusProvider provider(mock_signin_manager_->signin_global_error());
   provider.SetAuthError(error);
   EXPECT_CALL(*mock_pss_, IsSyncEnabledAndLoggedIn()).WillRepeatedly(
       Return(true));
   EXPECT_CALL(*mock_pss_, IsSyncTokenAvailable()).WillRepeatedly(
       Return(true));
   EXPECT_CALL(*mock_pss_, waiting_for_auth()).WillRepeatedly(Return(false));
   EXPECT_CALL(*mock_pss_, GetAuthError()).WillRepeatedly(ReturnRef(error));
   EXPECT_CALL(*mock_pss_, HasUnrecoverableError()).WillRepeatedly(
       Return(false));
   EXPECT_CALL(*mock_pss_, sync_initialized()).WillRepeatedly(Return(true));
   // Any error should result in SigninFailed() being called.
   EXPECT_CALL(observer_, SigninFailed(error));
   tracker_.reset(new SigninTracker(profile_.get(), &observer_,
                                    SigninTracker::SERVICES_INITIALIZING));
 }
 
 
 TEST_F(SigninTrackerTest, SigninFailedWhenInitializing) {
   tracker_.reset();
   // SigninFailed() should be called.
   GoogleServiceAuthError error(GoogleServiceAuthError::REQUEST_CANCELED);
   EXPECT_CALL(observer_, SigninFailed(error));
   tracker_.reset(new SigninTracker(profile_.get(), &observer_,
                                    SigninTracker::SERVICES_INITIALIZING));
   tracker_->OnStateChanged();
 }