Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 12502009: Make gl_tests apk for android (Closed)

Created:
7 years, 9 months ago by greggman
Modified:
7 years, 9 months ago
Reviewers:
Yaron, Isaac (away), nilesh
CC:
chromium-reviews, apatrick_chromium, cjhopman
Visibility:
Public.

Description

Make gl_tests apk for android BUG=180432 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189109

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M build/all_android.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/gl_tests_main.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 3 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Hey Issac PTAL This seems to get the gl_tests to run on android. I suspect ...
7 years, 9 months ago (2013-03-18 21:27:52 UTC) #1
Isaac (away)
+Nilesh, Yaron, Chris. This change looks fine. If your tests pass on galaxy nexus, I'd ...
7 years, 9 months ago (2013-03-19 06:40:56 UTC) #2
greggman
In the interest of keeping CLs small and I check this in as is and ...
7 years, 9 months ago (2013-03-19 15:18:39 UTC) #3
nilesh
LGTM
7 years, 9 months ago (2013-03-19 16:14:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12502009/4001
7 years, 9 months ago (2013-03-19 16:22:35 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 21:26:51 UTC) #6
Message was sent while issue was closed.
Change committed as 189109

Powered by Google App Engine
This is Rietveld 408576698