Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/common/instant_restricted_id_cache.h

Issue 12498002: InstantExtended: Adding InstantRestrictedIDCache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing android compile error. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/instant_restricted_id_cache_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_COMMON_INSTANT_RESTRICTED_ID_CACHE_H_
6 #define CHROME_COMMON_INSTANT_RESTRICTED_ID_CACHE_H_
7
8 #include <set>
9 #include <utility>
10 #include <vector>
11
12 #include "base/containers/mru_cache.h"
13 #include "base/gtest_prod_util.h"
14 #include "base/logging.h"
15 #include "chrome/common/instant_types.h"
16
17 // In InstantExtended, iframes are used to display objects which can only be
18 // referenced by the Instant page using an ID (restricted ID). These IDs need to
19 // be unique and cached for a while so that the SearchBox API can fetch the
20 // object info based on the ID when required by the Instant page. The reason to
21 // use a cache of N items as against just the last set of results is that there
22 // may be race conditions - e.g. the user clicks on a result being shown but the
23 // result set has internally changed but not yet been displayed.
24 //
25 // The cache can be used in two modes:
26 //
27 // 1. To store items and assign restricted IDs to them. The cache will store
28 // a max of |max_cache_size_| items and assign them unique IDs.
29 //
30 // 2. To store items that already have restricted IDs assigned to them (e.g.
31 // from another instance of the cache). The cache will then not generate IDs
32 // and does not make any guarantees of the uniqueness of the IDs. If multiple
33 // items are inserted with the same ID, the cache will return the last
34 // inserted item in GetItemWithRestrictedID() call.
35
36 // T needs to be copyable.
37 template <typename T>
38 class InstantRestrictedIDCache {
39 public:
40 typedef std::pair<InstantRestrictedID, T> ItemIDPair;
41 typedef std::vector<T> ItemVector;
42 typedef std::vector<ItemIDPair> ItemIDVector;
43
44 explicit InstantRestrictedIDCache(size_t max_cache_size);
45 ~InstantRestrictedIDCache();
46
47 // Adds items to the cache, assigning restricted IDs in the process. May
48 // delete older items from the cache. |items.size()| has to be less than max
49 // cache size.
50 void AddItems(const ItemVector& items);
51
52 // Adds items to the cache using the supplied restricted IDs. May delete
53 // older items from the cache. No two entries in |items| should have the same
54 // InstantRestrictedID. |items.size()| has to be less than max cache size.
55 void AddItemsWithRestrictedID(const ItemIDVector& items);
56
57 // Returns the last set of items added to the cache either via AddItems() or
58 // AddItemsWithRestrictedID().
59 void GetCurrentItems(ItemIDVector* items) const;
60
61 // Returns true if the |restricted_id| is present in the cache and if so,
62 // returns a copy of the item.
63 bool GetItemWithRestrictedID(InstantRestrictedID restricted_id,
64 T* item) const;
65
66 private:
67 FRIEND_TEST_ALL_PREFIXES(InstantRestrictedIDCacheTest, AutoIDGeneration);
68 FRIEND_TEST_ALL_PREFIXES(InstantRestrictedIDCacheTest, CrazyIDGeneration);
69 FRIEND_TEST_ALL_PREFIXES(InstantRestrictedIDCacheTest, ManualIDGeneration);
70 FRIEND_TEST_ALL_PREFIXES(InstantRestrictedIDCacheTest, MixIDGeneration);
71
72 typedef base::MRUCache<InstantRestrictedID, T> CacheImpl;
73
74 mutable CacheImpl cache_;
75 typename CacheImpl::reverse_iterator last_add_start_;
76 InstantRestrictedID last_restricted_id_;
77
78 DISALLOW_COPY_AND_ASSIGN(InstantRestrictedIDCache);
79 };
80
81 template <typename T>
82 InstantRestrictedIDCache<T>::InstantRestrictedIDCache(size_t max_cache_size)
83 : cache_(max_cache_size),
84 last_add_start_(cache_.rend()),
85 last_restricted_id_(0) {
86 DCHECK(max_cache_size);
87 }
88
89 template <typename T>
90 InstantRestrictedIDCache<T>::~InstantRestrictedIDCache() {
91 }
92
93 template <typename T>
94 void InstantRestrictedIDCache<T>::AddItems(const ItemVector& items) {
95 if (items.size() == 0 || items.size() > cache_.max_size())
96 return;
97
98 for (size_t i = 0; i < items.size(); ++i) {
99 InstantRestrictedID id = ++last_restricted_id_;
100 cache_.Put(id, items[i]);
101 if (i == 0)
102 last_add_start_ = --cache_.rend();
103 }
104 }
105
106 template <typename T>
107 void InstantRestrictedIDCache<T>::AddItemsWithRestrictedID(
108 const ItemIDVector& items) {
109 if (items.size() == 0 || items.size() > cache_.max_size())
110 return;
111
112 std::set<InstantRestrictedID> ids_added;
113 for (size_t i = 0; i < items.size(); ++i) {
114 const ItemIDPair& item_id = items[i];
115
116 DCHECK(ids_added.find(item_id.first) == ids_added.end());
117 ids_added.insert(item_id.first);
118
119 cache_.Put(item_id.first, item_id.second);
120 if (i == 0)
121 last_add_start_ = --cache_.rend();
122 last_restricted_id_ = std::max(item_id.first, last_restricted_id_);
123 }
124 }
125
126 template <typename T>
127 void InstantRestrictedIDCache<T>::GetCurrentItems(ItemIDVector* items) const {
128 items->clear();
129
130 for (typename CacheImpl::reverse_iterator it = last_add_start_;
131 it != cache_.rend(); ++it) {
132 items->push_back(std::make_pair(it->first, it->second));
133 }
134 }
135
136 template <typename T>
137 bool InstantRestrictedIDCache<T>::GetItemWithRestrictedID(
138 InstantRestrictedID restricted_id,
139 T* item) const {
140 DCHECK(item);
141
142 typename CacheImpl::const_iterator cache_it = cache_.Peek(restricted_id);
143 if (cache_it == cache_.end())
144 return false;
145 *item = cache_it->second;
146 return true;
147 }
148
149 #endif // CHROME_COMMON_INSTANT_RESTRICTED_ID_CACHE_H_
OLDNEW
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | chrome/common/instant_restricted_id_cache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698